Bugzilla – Bug 3235
Inconsistent behaviour when clicking on track name
Last modified: 2006-04-12 03:16:49 UTC
There are various places in the default skin which display a list of tracks, where each row in the list says "[trackname] from [album] by [artist]" In most cases all three hyperlinks open a page about the track, album, or artist, in the frame on the left. This is good - except sometimes the [trackname] link behaves inconsistently. One notable inconsistency is when the "[trackname] from [album] by [artist]" appears in the current playlist, in the frame on the right. The [album] and [artist] hyperlinks behave as normal. However the [trackname] hyperlink does not. I expect it to take me to the track information page, but instead it starts that track playing. This is a big suprise, and not very friendly. Why not include the familiar right-pointing-triangle button in the current playlist display for this function, and keep the click-on-trackname behaviour consistent too? (6.5b1, ubuntu breezy, a nightly .deb from last week)
which skin? Default, Fishbone, Light at least should go to songinfo from the track title link. In the case of Fishbone, if you click on the playlist item number (the digit at the left margin) then it is a different link and jumps to that track (to avoid the added clutter of another button)
> which skin? > Default, Fishbone, Light at least should go to songinfo from the track title link. No problems with Fishbone, but Default and Light are *definitely* behaving in the confusing manner I described previously. (I was previously using Default, and Ive just tested Light). The tip that it works in Fishbone was enough help for me track down the code responsible for this. It looks like there is a specific branch in the Default skin for the behaviour I described as 'inconsistent'. Removing this code fixes my immediate problem, but I'm not sure what else it breaks. Patch to be attached.
Created attachment 1177 [details] HTML/Default/cmdwrappers_Default patch Patch so that clicking a track title in the current playlist takes you the songinfo page, rather than jumping to playing that track.
sorry. bad recall on my part. the track title link has been a jump to that song url in the Default skin, by design. Checking back in the archives, it appears to have always been this way. I'll have to mark this as an enhancement, since this does work currently as designed. I'll let Dean make the call on the ui behaviour change, since this is the Default skin.
I"m good with adding a play icon/word in the now playing list and making the title always open the song info page. but it does need to be consistent across skins.
some skins are already doing something like this, so I can leave them alone. the rest will be done tonight. ajax skins (default2, exbrowse3 and soon nokia770) will have to be up to the respective owners to fix
updated at change 6820, for april 4 build of 6.5. Please try that out and confirm if that works for you.
This update works well. Is there a reason that artists aren't linked separately from the track title? I was recently noticing that you can't go from a track in the playlist to a list of an artist's albums. This is something you might want to do from either a saved playlist or playing in random mode. It's easy enough to get to the album track list, but the browse mode is set to 'Browse Albums' and there's no cookie crumb link to the artist. The same type of link is is also in the album track list itself, with track name and artist joined and linked only to the track detail.
The link depends on your titleformat. If you include ARTIST in teh web titleformat, there is no separate link, as the whole titleformat is used for the title link. If you only have TITLE, then you will get a separate artist and album link.
Fix looks good. thanks