Bug 3224 – One Genre missing from Advanced Search drop down

Bug 3224 - One Genre missing from Advanced Search drop down

Summary:

One Genre missing from Advanced Search drop down

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.2.2
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-03-29 09:54 UTC by Ceejay
Modified:	2008-09-15 14:38 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ceejay 2006-03-29 09:54:04 UTC

Seen in 6.2.1 and 6.2.2 ... The Advanced Search field for Genre - which should be a drop down with all valid values of Genre - is missing one value.  In my case, with 6.2.2, it is missing the genre "Vocal", which I see in my database has the ID of 1.  Looking in advanced_search.html I see the line "[% NEXT IF NOT genre.name OR genre.id == 1 %]" which may be relevant?

I tried this in an old version of 6.5 I have installed on another machine - there I'm also missing one Genre, but its the "No Genre" value, which seems a bit more sensible.  Is omitting Genre 1 deliberate, on the assumption its always "No Genre" ? Or is there something else going on in the logic I don't understand?

Either way, its definitely broken in 6.2.2 and another user has reported something similar in 6.2.1

Ceejay.

Comment 1 Mike Cappella 2006-03-29 10:58:07 UTC

I believe the line:

	[% NEXT IF NOT genre.name OR genre.id == 1 %]

should be

	[% NEXT IF NOT genre.name %]

I've verified it works for me.

Comment 2 KDF 2006-04-21 14:59:37 UTC

Dan,  does the "no genre" at genre id=1 still have any application with 6.2.2 or can we go ahead with this patch in order to make it for 6.2.2?

Comment 3 Dan Sully 2006-04-22 15:05:26 UTC

Fixed in change 7053