Bug 3175 - Crash trying to browse real audio files
: Crash trying to browse real audio files
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.2.2
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-03-16 18:03 UTC by Marc Auslander
Modified: 2008-09-15 14:38 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Auslander 2006-03-16 18:03:39 UTC
The following information is part of the event: Not a SCALAR reference at /PerlApp/Slim/Web/HTTP.pm line 955.

I was flailing around trying to see if I could get .rm files to play.  

I put some in a directory, then navigated there using Browse Music service.

I then navigated to the folder with the .rm file, clicked on a file, then clicked on edit.  The above crash resulted.
Comment 1 Dan Sully 2006-04-22 14:53:49 UTC
Marc - I'm not sure what you mean by "Clicked on Edit". Where in the web UI was this?

The .rm files in my tree don't show in my Browse Music Folder at all.

Does this still happen for you in the latest 6.2.2 nightly?

Thanks.
Comment 2 KDF 2006-04-25 13:41:25 UTC
clicked on edit...seems like this file was in the playlist folder.  However, testing with the latest build, placing a .rm file in the music folder still allows it to be edited as if it were a playlist.  Placing the file in the playlist folder, and clicking edit is fine.  Placing it in music folder and click edit, the crash described above happens.
Comment 3 Dan Sully 2006-04-25 13:48:11 UTC
Where are you clicking on 'Edit' when it's in the Music Folder?

I'm not even seeing the .rm file show up..
Comment 4 KDF 2006-04-25 13:49:08 UTC
one possible quick fix, line 1521 of Slim/Web/Pages.pm changes to:

if ($item->isPlaylist) {

This adds the noEdit param to ALL playlists found in the music folder, so that we don't end up with the edit option and trigger the crash. Currently, this only adds noEdit to CUE sheets.
Comment 5 KDF 2006-04-25 13:52:41 UTC
You have to have the AlienBBC plugin installed in order to have .rm recognised
as a type.  To test, I simply added the required line to types.conf (which
alienBBC adds via Alien/custom-types.conf:

rtsppl    rm,ram,rpm,smil  ?                            playlist


Then, I placed the .rm file in the root of the music folder, and the root of
the playlist folder.

Rescan, or just navigate browse music folder.
The playlist file should show up.  Click on it, and you get the "browse
playlist" page with the "rename, edit, delete" form at the top.  Clicking on
edit causes the crash. With the fix I mentioned above, it is just a listing
(provided the rm points to valid files)
Comment 6 Dan Sully 2006-04-25 14:29:57 UTC
KDF - please check this in tonight after we've done 6.2.2
Comment 7 KDF 2006-04-25 22:06:08 UTC
committed to trunk at change 7136.  Holding off from stable branch until after official 6.2.2 or was it just for the FC1 tag?
Comment 8 Dan Sully 2006-04-26 14:19:46 UTC
Applied to the 6.3 branch as change 7149
Comment 9 Chris Owens 2006-06-27 14:21:44 UTC
This bug fix is now part of a released version, and so has been marked closed. If you are still experiencing this problem, please reopen the bug.