Bugzilla – Bug 316
slimserver dies if you try to view songinfo and no player are found
Last modified: 2008-09-15 14:37:04 UTC
If you start slimserver but haven't pointed a player at it yet, it will die when you try to view song info (in the web interface of course). The message on the console is ... Can't call method "id" on an undefined value at /usr/src/slim-tmp/server/Slim/Utils/Prefs.pm line 460. A simple cheezy hack is to have clientGet() return 0 when no client is defined, but I don't know what effect that would have elsewhere in the system. (it seems to work upon casual inspection. returning non numeric values seems to cause other error messages, but will still keep it from dying.) anyway, in case it helps, here's a patch for the quick hack... Index: Slim/Utils/Prefs.pm =================================================================== RCS file: /cvsroot/slim/server/Slim/Utils/Prefs.pm,v retrieving revision 1.65 diff -u -r1.65 Prefs.pm --- Slim/Utils/Prefs.pm 18 May 2004 22:50:12 -0000 1.65 +++ Slim/Utils/Prefs.pm 19 May 2004 21:36:23 -0000 @@ -454,6 +454,7 @@ my $client = shift; my $key = shift; my $ind = shift; + return 0 unless defined $client; if (defined($ind)) { return getInd($client->id() . "-" . $key,$ind); } else {
Ah found the problem, kevin, can you take a look at it: 2004-05-19 18:08:35.6924 Backtrace: frame 0: Slim::Utils::Prefs::clientGet (/Users/dean/slim/server/Slim/Utils/Prefs.pm line 528) frame 1: Slim::Utils::Prefs::setMaxRate (/Users/dean/slim/server/Slim/Player/Source.pm line 1055) frame 2: Slim::Player::Source::underMax (/Users/dean/slim/server/Slim/Web/Pages.pm line 1017) frame 3: Slim::Web::Pages::_addSongInfo (/Users/dean/slim/server/Slim/Web/Pages.pm line 1085) frame 4: Slim::Web::Pages::songInfo (/Users/dean/slim/server/Slim/Web/HTTP.pm line 631) frame 5: Slim::Web::HTTP::generateHTTPResponse (/Users/dean/slim/server/Slim/Web/HTTP.pm line 553) frame 6: Slim::Web::HTTP::processURL (/Users/dean/slim/server/Slim/Web/HTTP.pm line 429) frame 7: Slim::Web::HTTP::processHTTP (/Users/dean/slim/server/Slim/Networking/Select.pm line 91) frame 8: Slim::Networking::Select::select (./slimserver.pl line 422) frame 9: main::idle (./slimserver.pl line 364) frame 10: main::main (./slimserver.pl line 821)
haha! already on it. The Web UI was set to display the converted bitrate... However, I've noticed we would want it on current song only. songinfo will go by file info alone and status will show converted rate. This will fix this crash.
patch committed to cvs. please confirm if May 20 nightly fixes the issue for you.
looks much better to me thanks
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006. I am setting them to targets of 6.2.1 to keep them from showing up in my queries.