Bugzilla – Bug 3078
Missing error for empty directory on play
Last modified: 2008-09-15 14:39:24 UTC
When you press play on a directory (browse music folder) that contains files that the squeezebox can't immediately play (for example, if a directory is empty or contains non-music files), there is no visual feedback on the display. No error message or information to inform the user that no music exists here. Sometimes this can be really frustrating if you -think- there is music in that directory and in reality there isn't. More of a usability improvement I guess but its driven me crazy a couple of times recently. Chris. (Street_Samurai) p.s. you might want to adjust some of the settings for this bugs, some of the fields were non-intuitive to me... is this a Graphics Component bug or Misc...?
Dean - thoughts on this?
Dean?
tried this with an empty folder, svn 8675, and I'm seeing "ERROR: Can't open remote url" shown on the top line when pressing play.
Ok, first we should fix the problem that kdf describes. At a minimum it should say: Now Playing Folder Name -------------------- If, after scanning the folder it ends up playing/adding no songs, there should be a showbriefly message that says: Problem: No songs in this folder.
the error is spit from _playlistXitem_load_done, which does allow an $error in the args. woudl probably work to just supply that $error arg when the load fails.
in fact, simply changing line 27 of Slim::Utils::Scanner seems to give the desired UI: return $cb->( $foundItems || [], scalar @{$foundItems} ? undef : 'PLAYLIST_EMPTY' ); if course, the string could be anything, but this was a somewhat applicable one that already exists in strings.txt
Commited kdf's patch in change 9089