Bugzilla – Bug 3045
Change in Request.pm 6318 introduced new bug
Last modified: 2006-02-22 13:42:27 UTC
The change in Request.pm 6318 to add utf encoding of inputs introduced a new bug. The change does not take into account that some of the parameters can be lists/hashes/objects. It treats every parameter as a scalar, the encoding then replaces the object with a string breaking all sorts of things. The bug materialised for me with the RandomPlay plugin using play songs mix. I saw lots of 'url is empty' backtraces. Not sure of the 'proper' fix, but here are some suggestions: 1) reverting the change seems to work for me 2) only encoding scalars seems reasonable, but is it necessary to recurse the objects/arrays/hashes. It seems dangerous to tamper with an objects attributes from outside. In my environment I've reverted and the previous version is running smoothly. Malcolm
"Me too" report - I'm seeing the same error. It appears when there is nothing in the playlist or when changing songs.
It seems this only appears when using Random Play.
Fixed in change 6340
Dan, have upgraded to 6340 but am still seeing the same error. This is just with Random Play.
Submitted an alternate fix in 6341, which basically removes the offending code and have the CLI control the encoding fix. The CLI cannot have refs as params, only scalars. Tried RandomPlay with it and works for me.