Bug 3036 – Buffer fullness pref. problem

Bug 3036 - Buffer fullness pref. problem

Summary:

Buffer fullness pref. problem

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	6.5b1
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	KDF

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-02-20 12:27 UTC by sbjaerum
Modified:	2006-02-20 18:21 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Enable buffer fullness display on SB1/SBG (1.73 KB, patch) 2006-02-20 12:28 UTC, sbjaerum	Details \| Diff
Enable bar in buffer display on SB2 (500 bytes, patch) 2006-02-20 12:32 UTC, sbjaerum	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description sbjaerum 2006-02-20 12:27:55 UTC

The web setup for displaying buffer fullness does not set the showbufferfullness parameter anymore. A result of this is that it is not possible to display the buffer fullness on SB1/SBG without manually editing the pref file and set the showbufferfullness to 1. I propose the attached patch to Player.pm that removes the test for the showbufferfullness parameter as this test is not needed with the current setup method. With this patch the SETUP_SHOWBUFFERFULLNESS_CHOOSE section in strings.txt should also be removed (because of the encoding of this file, I'm unable to provide a diff including this).

Comment 1 sbjaerum 2006-02-20 12:28:57 UTC

Created attachment 1147 [details]
Enable buffer fullness display on SB1/SBG

Comment 2 sbjaerum 2006-02-20 12:32:25 UTC

Created attachment 1148 [details]
Enable bar in buffer display on SB2

I am not sure if it is intentional, but there is no longer any bar display associated with the buffer fullness display on SB2. This patch fixes this.

Comment 3 KDF 2006-02-20 15:03:38 UTC

good catch.  I'll take care of merging this.

Comment 4 KDF 2006-02-20 18:21:31 UTC

added to trunk at change 6322. thanks!