Bug 2988 - Artwork on album page should have a reasonable maximum default
: Artwork on album page should have a reasonable maximum default
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.5b1
: All All
: P2 minor with 2 votes (vote)
: ---
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-12 11:29 UTC by Jim McAtee
Modified: 2009-09-08 09:17 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
the simple fix (519 bytes, patch)
2006-06-17 11:24 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2006-02-12 11:29:41 UTC
There should be a pref for maximum "full" artwork size, as displayed on the album page.  If a cover's dimensions exceed this size, SlimServer should resize and cache the "full-sized" image in the same manner that it does for thumbnails on the browse artwork pages.  If the image is smaller than the set size, then it should not be resized.  Clicking on the resized image should display the original in a new window, as it does now.
Comment 1 KDF 2006-02-12 11:36:14 UTC
a number of users seem to feel that looking at the targets will tell them when the  various issues ARE going to be fixed.  In light of that, it should really be up to those who are taking the burden of making it work to determine when it can be done. 
Comment 2 KDF 2006-02-16 21:14:10 UTC
there is a javascript that already sizes the artwork to the frame.
Comment 3 Jim McAtee 2006-02-16 21:31:40 UTC
Yes, I've noticed that the artwork never exceeds the width of the frame, which is good, but that's usually too large, with the track list appearing well down the page.  Of course you can control it yourself by limiting the size of the artwork that you scan or download, or by resizing it yourself, but with the capability SlimServer has to resize images, setting a pref and having all artwork on the album pages kept within a set size would save a lot of work.  Plus it would still leave you with the ability to view the full-sized artwork on the next click.

I think you'd still want to retain the JavaScript routine for people who choose to set the max size to 2000 pixels or 'unrestricted' or whatever.
Comment 4 KDF 2006-02-17 00:01:20 UTC
personally, I feel there needs to be a real reason for a pref...we have too many already. it is a never ending loop requiring prefs, and dealing with those who complain that there are too many prefs.  It is also possible for any skin
 to be designed with a fixed cover art size (which is what it used to be until people complained, etc etc)
Comment 5 Jim McAtee 2006-02-17 00:25:20 UTC
Of course it's never ending.  That goes without saying.  If there 
are 100 prefs today, you can bet that some day there will be 200.

There aren't too many - the complaints are that people can't find 
them and often can't understand them.  But that's due to the 
interface being poorly organized, with many prefs not documented 
well.  I doubt there are many complaints from users about having
too much control over the server.

So mark it low priority or write it off.  I thought that with the 
ability to resize artwork, and the current pref for thumbnail
sizing that this one was a gimme that made perfect sense.
Comment 6 Blackketter Dean 2006-04-22 19:26:59 UTC
I think that having a well chosen image size for the page that doesn't overwhelm (and hide other information) and that's clickable to bring up the full size image (like amazon does) is probably a good solution that doesn't require a pref.

Since this is an enhancement request, it's going to need to be moved to 6.5.
Comment 7 Jim McAtee 2006-06-13 01:28:35 UTC
Why was this moved from target 6.5 to future?  If you don't want to deal with it, then mark it INVALID.  Christ, 6.5 is many months in the future, so why are you already pushing enhancement requests into the black hole of 'future'?



Comment 8 Blackketter Dean 2006-06-13 07:51:59 UTC
Let's make the maximum size on that page smaller than the full width of the pane, probably about half of the width (it shouldn't block the song list).  This should be a trivial change to the HTML to include the targeted size.

FWIW: 6.5 is on a fast track and is targeted for final release at the end of july, that's why we're punting on new features, but since this is a simple layout issue we'll take it now.
Comment 9 KDF 2006-06-17 11:24:21 UTC
Created attachment 1274 [details]
the simple fix

the "simple" way is attached.  much more complicated to track client width and somehow send back to TT to use the GD resizing (but I plan to have nothing to do with that).  So, you get that moment of large, then it snaps to size.  it is also browser resizing.  
I look forward to watching this issue be rehashed indefinately.
Comment 10 Chris Owens 2006-08-16 15:18:27 UTC
KDF, Dean and Dan say the patch looks good, and Dean says to put it in.
Comment 11 Blackketter Dean 2006-08-22 11:43:30 UTC
Is this done?
Comment 12 KDF 2006-08-28 17:01:08 UTC
I'll merge tonight.
Comment 13 KDF 2006-08-28 18:35:21 UTC
in trunk at change 9227, 6.5 branch at change 9228