Bug 2980 - Wrong clip plays
: Wrong clip plays
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Playlists
: 6.2.2
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-11 15:54 UTC by Marc Auslander
Modified: 2006-02-13 17:54 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Auslander 2006-02-11 15:54:56 UTC
I have a music folder with many clips.

If I do browse music folder, then use up-down to select a clip, then press play the following happens.

The whole folder content populates the playlist.
The clip following the one I selected starts playing.

If I then move up in the playlist to select the correct clip again and press play, the correct clip starts.

2-10 nightly 6.2.2
Comment 1 KDF 2006-02-11 16:26:30 UTC
A possible fix to this was put in to 6.5b1 as a repsonse to bug 2653.  Please try the 6.5 and let us know if that fixes this issue.  If so, it might be possible to backport it to 6.2
Comment 2 Marc Auslander 2006-02-12 06:39:53 UTC
More info.
651b behaves the same way.
May not matter but I run in treat multi-disc sets as a single album mode.

My music folder contains mostly simple MP3 files.  At the start (in sorted order) are three folders.  Down aways in the (sorted) list is another folder which contains tracks with track info.  Slim recognizes this folder as an album.

Tracks above this middle folder start correctly.  Tracks below this folder show the one off but - one track later than the one selected is actually played.  So maybe some counter it inconsistent between the main music folder and the playlist because of this included folder.

It is the case that the subfolders, including the one in the middle, do not appear in the playlist.
Comment 3 KDF 2006-02-12 12:02:10 UTC
A subfolder should not be recognised as an album.  That is a bit worrying.  Are the contents of the folder a single album?  What is it that makes you believe this folder is being recognised as an album?  Could it just be that the folder is the same name as an album tag in the files?  

subfolders should not be added, so this last bit would make sense.

I haven't been able to reproduce a case like this.  The function works by adding anything that is a recognised song, and should ignore anything that is not a song.  As such, it would seem that this strange folder would be a good place to start.
Comment 4 Marc Auslander 2006-02-12 12:23:41 UTC
I misspoke.  The contents of the folder are recognized as an album with the album name - not the folder name.  The folder just contains a bunch of mp3 files with tags.

The folder does NOT get added to the playlist - this is correct as you say.

I suspect though that the folder is being counted to compute the clip number - remember I'm pressing play from the browse music folder page.  At least, this explaination would account for playing the next clip down.

If I switch to the playlist, find the same clip, and press play the correct clip does play.

I'd be happy to help debug this if you tell me what to do -  but I'm not a perl programmer.
Comment 5 Marc Auslander 2006-02-12 12:25:57 UTC
On other fact.  The music folder is a samba export from a Linux file server.
Comment 6 KDF 2006-02-12 15:21:44 UTC
actually, I think I may have this fixed in change 6227.  I set up a case that could show the problem, and I've managed to sort that one out.  Please try the Jan 13 build of 6.5 and let us know if that work.  If it is good, I'll see what I can do about porting it back into 6.2.2
Comment 7 Marc Auslander 2006-02-13 05:36:28 UTC
651b 2-13 fixes this bug.  Tested with one, and then with two seperate folders imbedded in the clip list.  Both tests still fail off by one in 6.2.2 2-10

I was surprised to find that this is always off by one - so my guess above about counting is wrong.  But happily KDF figured it out.  Thanks - hope you can fix 6.2.2 as well.

I didn't change the resolution - I'm not confident of the procedures here yet.
Comment 8 KDF 2006-02-13 10:33:53 UTC
Thanks for confirming this.  I have a couple of other tests I want to do tonight before I merge this into 6.2.2, but I expect it should be able to make it into the Feb 14 nightly. 
Comment 9 KDF 2006-02-13 17:54:44 UTC
committed to 6.2.2 at change 6240, for Feb 14 build.  I've tested on linux with a reprducable case.  Also checked that selecting a folder will simply play that folder.  For play all to work, the selected item MUST be recognised by the server as a song