Bug 2940 - Editing names of items in a playlist does not save the amendments to disk
: Editing names of items in a playlist does not save the amendments to disk
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Playlists
: 6.2.2
: PC Windows XP
: P2 minor (vote)
: ---
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-06 15:29 UTC by Philip Meyer
Modified: 2006-02-07 18:12 UTC (History)
0 users

See Also:
Category: ---


Attachments
add titles when using writeList to save an edited playlist (486 bytes, patch)
2006-02-07 00:28 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2006-02-06 15:29:45 UTC
I had an m3u playlist file on disk that was loaded into SlimServer DB.  This playlist file only had a list of urls (radio stations), so within SlimServer each entry in the playlist had a name that was the same as the url.  I edited the name for each entry to be something more appropriate, but the edits are not automatically stored back to disk.

Hence when rescanning the library, the names are lost.

As a workaround, I rename the playlist and then rename it back to the original name - this flushes the edits back to disk (however, bug <a href="https://bugs-archive.lyrion.org/show_bug.cgi?id=2939">2939</a> causes a duplicate file to be created).
Comment 1 Philip Meyer 2006-02-06 15:30:50 UTC
Okay, so <a> tags don't work - how do people put hyperlinks to other bugs into these comments?
Comment 2 KDF 2006-02-06 15:57:23 UTC
just say "bug xxxx" and bugzilla does it automatically.
Comment 3 KDF 2006-02-07 00:28:52 UTC
Created attachment 1129 [details]
add titles when using writeList to save an edited playlist

This uses the addTitles flag to addd the EXTINF comments to an edited playlist.  this works for m3u.  pls files seem to add titles when writing out regardless, so those should already be working.
Comment 4 Dan Sully 2006-02-07 09:59:09 UTC
Looks good.
Comment 5 Philip Meyer 2006-02-07 11:54:44 UTC
Not sure if you intended me to try this patch...

I have tried to apply it, but I'm only on 6.2.2 and Tortoise SVN believes the file has changed since the patch was made.

I'm assuming the patch will be applied to 6.5 and then possibly merged to 6.2.2?
Comment 6 KDF 2006-02-07 12:48:37 UTC
it was a patch against 6.5, and simple enough to apply manually in any case (only 2 characters)

I pasted here becuase it was too late for the nightly, and if there was some reason NOT to be writing the EXTINF, I didn't want to jump in a bugger things up where I wasn't sure.  You know, more users bitching that developers don't think and test, etc :)

I'll patch both tonight.
Comment 7 Philip Meyer 2006-02-07 12:55:52 UTC
I understand ;)

Thanks for the quick fix, and for informing me about the "bug xxxx" trick!
Comment 8 KDF 2006-02-07 18:12:44 UTC
committed to trunk at change 6123
6.2.2 branch at change 6124