Bugzilla – Bug 2891
"repeat 2" ignored if set late
Last modified: 2009-09-08 09:32:13 UTC
As a playlist is getting near to ending, I sometimes think "ok, let's have that again", and I send a "repeat 2". It gets ignored; apparently you have to specify repeat at the beginning of play, not near the end. Annoying.
changing the repeat state, probably needs to reset playmodes and change playout-stop to playout-play.
I'll take a look at this tonight. I've assumed this was nto so much cli related, as command related. I expect any repeat change is missed, but hopefully they all run through Control::Commands by now :) It should just be a case of checking playmode and resetting (I hope)
Created attachment 1115 [details] 6.2.2 patch possible fix committed to trunk at 5979. i've tested using the web ui. Please update to the Jan 31 build and let us know if this works out. I have an equivalent patch for 6.2.2 which I've attached for review. I don't want to commit until 6.5 fix is conirmed.
Created attachment 1122 [details] 6.5 patch using subscribe This needs more testing but should and seems to be working using subscribe. I guess turning the subscribe on and off isn't so much of an optimisation since it is global to all clients anyway. It could just be started on init. The callback checks to make sure that the requesting client is in a playout mode to at least narrow down the processing. The routine calls the playout sub, instead of the client method so that sync groups are handled.
kdf, did not see your patch until today, will have to try it...
Works for me. Fixed?
Fred, if the second patch works for you using the subscribe, feel free to merge. The first patch is the best that can be done as far as 6.2.2, but that depends on approval.
What's the status on this? Can the 6.2.2 patch be applied? Thanks.
6.5 patch applied at change 7034 6.2.2 patch applied at change 7035 please update and verify. reopen if there are issues.