Bug 2871 - Need to warn users of broken plugins after upgrade
: Need to warn users of broken plugins after upgrade
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugins
: 6.5b1
: PC Windows XP
: P2 enhancement (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-01-25 04:45 UTC by Ben Gladstone
Modified: 2011-07-22 03:45 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Gladstone 2006-01-25 04:45:42 UTC
The upgrade from 6.2 to 6.5 requires new versions of LazySearch and AlienBBC - if you don't upgrade these the slimserver crashes. Only by running it from a command line are you likely to see the cause, and not necessarily even then. For non-technical users, this will cause major problems. 

Ideally, slimserver should warn of plugins that need upgrading and disable them to prevent crashes. Could plugins carry some sort of version-certification that the server could query for this?
Comment 1 KDF 2006-01-25 09:05:32 UTC
They do. But, as is always said on this: it cannot cover everything that a plugin might try to do.
Comment 2 KDF 2006-01-25 11:33:57 UTC
what exactly is this crash?  event viewer/log please.

Only report I've seen in forum is that the plugin disappears from the plugin list, which is one of the safety measures already in place: not loading a plugin that doesn't pass the simple checks. 

running slim.exe --d_plugins isn't all that hard, but it might be a good improvement if the plugin failures were dumped to a log always, regardless of debug switches.  Of course, this will still not be able to stop a plugin from simply making a bad function call. Every effort is made to provide notices for deprecated function calls, and plenty of warning to developers to upgrade.  If there is a stub we can fix, then the log entry for the crash will point to it.
Comment 3 Ben Gladstone 2006-01-25 11:46:16 UTC
unfortunately i don't have the log for the lazysearch problem nor time to roll back and reproduce. as far as i remember the server crashed soon after starting. starting ss from the command line showed an error that mentioned lazy so i removed the lazysearch folder and all was fine 

alienbbc: see bug 2868 for trace. installing the new alienbbc solved this - but even with the trace i didn't realise it was due to alien and needed your prompting

my thinking is that plugins such as alien are such a strong selling point (radio-on-demand in your living room - a first!) that slimserver needs to make upgrades seamless for non-techies. i can appreciate the tech difficulties but i believe it's an important part of making slim a long-term success
Comment 4 Dan Sully 2006-06-13 00:14:54 UTC
Quite agreed, Ben - we need better user feedback in a lot of areas.

This isn't going to make 6.5 though. 
Comment 5 Michael Herger 2011-07-22 03:45:00 UTC
The new plugin handler should be able to warn the user about plugins requiring updates.