Bug 2870 – Viewing second page of to-be-saved playlist jumps to edit mode

Bug 2870 - Viewing second page of to-be-saved playlist jumps to edit mode

Summary:

Viewing second page of to-be-saved playlist jumps to edit mode

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Playlists
Version:	6.2.2
Platform:	PC Debian Linux

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-01-24 23:01 UTC by James A. Hillyerd
Modified:	2006-01-28 13:06 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
keep saveCurrentPlaylist param to stay out of edit mode (1.00 KB, patch) 2006-01-28 04:56 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James A. Hillyerd 2006-01-24 23:01:26 UTC

How to reproduce:
  Create a playlist that spans more than one page (in right pane)
  Click "SAVE" at top of playlist (in right pane)
  Click right arrow or page 2 of to-be-saved playlist (in left pane)

Server exits with the following message in log:

Slim::DataStores::DBI::Track->retrieve() parameters don't include defined values for all primary key columns (id) at /usr/local/SlimServer_6_2_x_v2006-01-24/Slim/DataStores/DBI/DBIStore.pm line 244

This is present in both 6.2.1 and 6.2.2 nightly for 1/24/06

Comment 1 KDF 2006-01-25 11:19:40 UTC

Slim/Web/Pages/EditPlaylist.pm, line 54 should be changed to:

my $playlist = $ds->objectForId('playlist', $params->{'playlist'});

since the Save Playlist routines use the 'playlist' param for the playlist id.

Comment 2 KDF 2006-01-26 21:18:14 UTC

committed a fix to 6.2.2 and 6.5 at change 5871.  This now avoids the crash, but the template used in the pagebar links is edit_playlist.html which causes the next page to be in edit mode instead of browse. eiting summary to reflect

Comment 3 KDF 2006-01-28 04:56:25 UTC

Created attachment 1114 [details]
keep saveCurrentPlaylist param to stay out of edit mode

entering save playlist mode leverages browsedb for output, but the pagebar lists edit_playlist as thepath, so clicking on them will automatically go into edit mode.  however, the saveCurrentPlaylist param can be used to once again redirect edit_playlist to bounce to browsedb again for each of the pagebar items.

Comment 4 Dan Sully 2006-01-28 09:12:18 UTC

Looks good. Thanks

Comment 5 KDF 2006-01-28 13:06:15 UTC

committed at change 5918