Bugzilla – Bug 2841
"Browse Into" Song info does not work if Artist tag is empty (FLAC)
Last modified: 2008-09-15 14:39:24 UTC
With FLAC files, you cannot browse to related items via Song Info if the file's Artist tag is empty. I am attaching to files (tracks) from the same classical CD. They are both by the same composer, and performed by the same orchestra. The Artist tag is empty in both files. By browsing into Song Info, you should be able to jump to each file from the other by clicking the right remote button on Album, Composer, Year or Orchestra, and an arrow is rendered nest to the text of these items. Clicking onthe right remote button, however, results only in a quick bump animation.
Jon - I don't see a file attached to this bug. Is this still an issue with the latest 6.2.2 nightly? Thanks
I think it will be, and I don't expect that any file oculd be made to trigger this. It comes down to this block of code in Buttons/Trackinfo: } elsif ($curitem =~ /^(?:ARTIST|COMPOSER|CONDUCTOR|BAND)$/) { my $lcItem = lc($curitem); my ($contributor) = $track->$lcItem(); Slim::Buttons::Common::pushMode($client, 'browsedb', { 'hierarchy' => 'album,track', 'level' => 0, 'findCriteria' => { 'artist' => $contributor->id }, 'selectionCriteria' => { 'track' => $track->id, 'album' => $album->id, 'artist' => $artist->id, }, }); If the composer, conductor, band or other role is selected, the find is still using "artist", which may not necessarily match the contributor id.
Ah yes.. this needs a good refactoring. Not sure if it will make it for 6.5
Fixed in change 8611