Bug 2815 - Live365 Search mode doesn't properly remove right arrow in search text
: Live365 Search mode doesn't properly remove right arrow in search text
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugin
: 6.2.1
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-01-12 12:54 UTC by Phil Fernandez
Modified: 2006-01-14 00:44 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Fernandez 2006-01-12 12:54:43 UTC
In the Live365 plugin player interface for search mode, the right arrow appended to the search text is not removed, so searches fail.  I have only reproduced / analyzed in 6.2.1, but the same code seems to be in 6.2.2 and 6.5b1.

The problem seems to be in in the doSearch() routine which contains the code:	my $arrow = $client->symbols('rightarrow');
	$searchString{$client} =~ s/$arrow//;

It does not appear that $client-symbols('rightarrow') returns the right value for right arrow -- it returns the single special character for right arrow, but the searchString text actually contains <dn>rightarrow<dn>.  Replacing this with:
	my $arrow = Slim::Display::Display::symbol('rightarrow');
corrects the problem.

See the attached log fragment from d_plugins on that shows that the search text sent to live365 in the search url contains the right arrow cruft.

2006-01-12 12:41:32.8689 Logging in philf1
2006-01-12 12:41:33.9807 Live365: Loading http://www.live365.com/cgi-bin/api_login.cgi?password=xxxxxxx&org=live365&action=login&remember=Y&member_name=philf1
2006-01-12 12:41:34.1243 Live365 logged in: philf1:xxxxxxx
2006-01-12 12:42:00.3503 Live365.doSearch exit input mode: 'nextChar'
2006-01-12 12:42:00.3503 Live365.doSearch string: 'ABCrightarrow'
2006-01-12 12:42:00.3696 Live365: Loading http://www.live365.com/cgi-bin/directory.cgi?source=Live365%3ARdRunnder%3ABT&maxspeed=256&rows=50&searchdesc=ABC%1Frightarrow%1F&first=1&searchgenre=All&access=ALL&genre=All&sort=B%3AD&site=xml&searchfields=T%3AA%3AC
Comment 1 KDF 2006-01-14 00:44:15 UTC
This should now be fixed as of svn5628, for 6.5 nightly builds and svn 5636 for 6.2.2 builds.  Please confirm, and reopen if there are any remaining issues.