Bugzilla – Bug 2798
implement forget command like other commands
Last modified: 2006-01-26 09:27:03 UTC
the forget command, used to forget a player, is implemented outside of execute.pm. It seems to be handled directly in Slim::Web::Pages.pm. This makes it difficult to, for instance, tell Slim to drop a player from a CLI or other command interface. Please implement as a CLI/STDIN/xPL etc command and route through execute.
See post 6 in the attached thread.
also bug 1686 would be easier to solve if this code were in place.
fred, do you think you could add this to the dispatcher?
(In reply to comment #3) > fred, do you think you could add this to the dispatcher? Fred "invited" me to submit this enhancement, so I'm sure he has something up his sleeve.
Request code done in 5637, including calls from Home.pm and SqueezeNetwork.pm. Did NOT change HTML to use (command/subcommand) mechanism.
(In reply to comment #5) > Request code done in 5637, including calls from Home.pm and SqueezeNetwork.pm. > Did NOT change HTML to use (command/subcommand) mechanism. Fred: I tested this tonight, and I can't get it to work. I can get the menu system forget to work, and it's instantaneous, as you would expect from any user issued command. But the same thing from the CLI does nothing. Is there a delay or something? If there is, there shouldn't be (not at this level of the code ... next level up, perhaps, in the code that detects that a player has gone away - as Dean said, burritos in the microwave shouldn't do it. But that's a heuristic for the next level up of code, which is going to turn around and call execute and expect it to just get done).
No delay. Works for me, but of course only for really gone players (i.e. if it still there and powered up it comes back immediately...) Issue is currently is the CLI does not echo the client correctly (because it is gone, duh :-( ). Will fix now.
(In reply to comment #7) > No delay. Works for me, but of course only for really gone players (i.e. if it > still there and powered up it comes back immediately...) I tried it first with a winamp instance playing stream.mp3. It was really gone because I had closed it. Is the code different for stream players? I also tried it with a real player, but can't recall if I disconnected it first. BTW, SB1s don't come back (at least, they don't any more ... I'm pretty sure they used to).
code added to html pages to use the CLI version as of change 5748
Thanks kdf. This is done and can be closed.
Fred: Should I be seeing this in 6.2 or only in 6.5?
only 6.5, as this is a new feature.