Bug 2767 – Slimserver rescan crashes on files with bad artwork tag

Bug 2767 - Slimserver rescan crashes on files with bad artwork tag

Summary:

Slimserver rescan crashes on files with bad artwork tag

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Tagging
Version:	6.5b1
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-12-30 17:33 UTC by Bill Burns
Modified:	2008-09-15 14:37 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
MP3 file with artwork tag (2.01 MB, application/octet-stream) 2005-12-30 17:35 UTC, Bill Burns	Details
second sample provided via emai (3.42 MB, application/octet-stream) 2006-01-01 12:24 UTC, KDF	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Bill Burns 2005-12-30 17:33:34 UTC

These files had artwork added with an add-on program, and worked OK until 6.5.  Now a rescan crashes SS to the prompt with the error:

Can't use string ("image/jpg") as a HASH ref while "strict refs" in use at C:/Program Files/SlimServer/server/Slim/Formats/MP3.pm line 204.

Comment 1 Bill Burns 2005-12-30 17:35:00 UTC

Created attachment 1085 [details]
MP3 file with artwork tag

Comment 2 KDF 2005-12-30 19:15:02 UTC

interestingly, this file works fine for me, 6.5svn:

          'YEAR' => '1976',
          'ARTIST' => 'Al Di Meola',
          'COMMENT' => '',
          'PIC' => {
                     'FORMAT' => 'image/jpeg',
                     'DATA' => '????JFIF??C ...more binary data...
                   },
          'TITLE' => 'Sarabande From Violin Sonata In B Minor',
          'ALBUM' => 'Land Of The Midnight Sun',
          'GENRE' => 'Jazz',
          'TAGVERSION' => 'ID3v2.3.0',
          'TRACKNUM' => '3'
        };

do you still have the file that you posted this same info from on the forum?

Comment 3 Bill Burns 2005-12-30 19:23:04 UTC

> do you still have the file that you posted this same info from on the forum?

Yes I do.  I moved it and the others with problems out of my music folder temporarily.

Comment 4 KDF 2005-12-30 23:07:16 UTC

please attach the original file that showed the problem for you.

Comment 5 KDF 2006-01-01 12:24:01 UTC

Created attachment 1087 [details]
second sample provided via emai

I have tested with this file, and with another sample given via email (attached now).  I have not been able to reproduce the crashes.  Scanning, in my case, completes and I am able to view the artwork as thumbnail and album art.  Bill has used the EXE install, and 5.8.6 for patching as instructed by Dan.  I'm using 5.8.7 under Debian.  My only guess left at this point is possibly some sort of conflict in the MP3::Info modules (since the one in slimserver is slightly customised), though I can't see how this could get confused using the EXE

Comment 6 Bill Burns 2006-01-01 16:58:29 UTC

Issue was resolved with a clean install of 6.5b1.  Thanks to kdf for help along the way.
This PC had been upgraded by writing the nightly EXE beta files over the previous version a couple of times a week for several months, so it's difficult to determine how the problem arose.

Comment 7 Chris Owens 2006-06-16 14:41:50 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.