Bugzilla – Bug 2758
CUE sheet support is broken (File now plays, but navigation impossible).
Last modified: 2008-09-15 14:37:04 UTC
When playing using a CUE sheet, the audio file plays (improvement over last release) but you can't forward/rewind or navigate tracks. Any attempt to navigate the album results in the the file starting over from the beginning, even though the track you tried to play is displayed on the screen. If the album is left alone to play the whole album will actually play, although the name of the first track stays on the screen. Not sure if this is useful, but when the album is left to play, everytime it repeats the next track in the album appears on the display. The third time the album repeats, the name of the third track is displayed, and so forth. I have tested this will many files, including FLAC and MP3 with the same result for each. I have confirmed the CUE files are valid with Foobar2000, Feurio, EAC and other players.
scanning will not be possible with CUE sheets as long as CUE sheets still need to be run through the transcoding to get to the start and stop points. skipping tracks should be possible, since the flc-flc transcoding should now have support for --skip and --until. Have you disabled the flc-flac transcoding by any chance? I'm taking the 'future' target off of this, so that it can be reviewed during one of the bugzilla parties and be set for 6.5 if it fits the timing.
Im a little confused by your reply. Flac - Flac is enabled, yet skipping between tracks does not work (it just resets and starts the audio file from the begining again). Same problem with MP3 also. The display also just shows the name of the first 'track' in the cue file, even when it had moved to the next. When the whole audio file has played through and is repeated, the display then shows the second 'track' etc. Whe you say scanning, you mean fastforwarding/rewinding yes? Will this ever be possible?
scanning/fwding non-native formats isn't possible at this time. There is a request for handing of that, but it is at the "patches welcome" stage. try looking at d_source output and see if the right start/end references are being used by the playback command.
Please attach a sample cue sheet that causes the problem. I have run a full CD rip to FLAC w/ cue as a test and each song plays when selected. need more to test with.
I have tested a FLAC w/ external CUE and each song plays fine on the latest svn (Dec 31 nightly build). mp3 does not, as there is no seek to the right song. Transcoded WAV is ok, native WAV is not (same problem as native mp3)
adding a couple debug lines in Source, openSong(): print "POSITION: ".sysseek($client->audioFilehandle, 44, 0)."\n"; print "POSITION: ".tell($client->audioFilehandle)."\n"; The output is POSITiON: 44 POSITION: 0 not sure where to go from that. guess I'll do some regression hunting tomorrow unless there are other suggestions.
Use: sysseek($client->audioFilehandle, 0, 1); instead of tell() - which only works on buffered output.
thanks. there is a clue there. using WAV, no matter what song I start with I get an initial offset of 44, and by the time it gets to the trackStartEvent, it's an offset of 294956. at least I know something is working, but I'll still have to regress to find where (if anywhere) that this worked before.
ok, this is something wrong in teh parsing. the offset isn't being done for each track. I'm on it.
Created attachment 1086 [details] update blockalign and audio_offset from basetrack I think the tag mapping is behind more of this. This patch gets the right attributes from the basetrack, with the right keys. however, internal CUE sheets apparently hit this at a different point so I'm not sure how well this will work with those. This does seem to work with WAV, FLAC and MP3 in the case of external CUE's
fix committed at chnage 5495, should be in time for the Jan 1 build. I've tested with an internal cue that I made myself (dubious validity, of course) and it plays ok, just has odd metadata (meaning just one track repeated). The selected song, however does play and the metaflac info shows only one track title anyway. i dont know how to get all of them in there, since the cuesheet import didn't do it. Please try the jan 1 build and let us know if this now works for you.
Dominic, as a side-note, bug 1426 covers an enhancement request for native whole-album flac handling so that fwd/rew scanning is possible.
the playback issue here is fixed. fwd/rew scanning is another issue covered by 1426 so I will close this off. and let the enhancement for scanning be handled as part of 1426
Is the build with this fix in available yet? I will download and verify ASAP. Thanks for your efforts, if it works for me you have made me a very happy man. Thank god for open source!
each nightly is built at 1am. These fixes are part of the Jan 3 nightlies for 6.5b1
It would seem track skipping is now posible with FLAC images, yet any MP3 images still are not working with cue's. Should this bug be re-opened?
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006. I am setting them to targets of 6.2.1 to keep them from showing up in my queries.