Bug 275 - Power button crashes server when players synced
: Power button crashes server when players synced
Status: RESOLVED FIXED
Product: SB 1
Classification: Unclassified
Component: Firmware
: unspecified
: Macintosh MacOS X 10
: P2 major (vote)
: ---
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-04-25 13:48 UTC by Tom Hahn
Modified: 2011-03-16 04:18 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hahn 2004-04-25 13:48:44 UTC
Sync two players.  Play one.  Hit pause, then Power.  Server program has to be restarted.

I was unable to test if putting the server machine to sleep, and waking it up again will now cause 
players to re-sync.  In fixing the Power bug, could you please check that that works too.

I've had these units for several months and am *really* looking forward to being able to use them!  All I 
need is for them to sync and stay synced under all circumstances.
Comment 1 Tom Hahn 2004-04-25 21:00:48 UTC
I forgot to mention I'm running 5.1.5
Comment 2 Blackketter Dean 2004-04-25 23:38:48 UTC
Kevin, have you seen this?
Comment 3 KDF 2004-04-25 23:52:11 UTC
it worked fine for me when it was added, but havent tried it out after other
updates have been done, so I'm not sure what to say.  Are they set to sync
power?  are they set to sync volume?  Are both plaers squeezebox? 
Comment 4 KDF 2004-04-27 09:42:22 UTC
I cannot reproduce this with current cvs code.
Comment 5 KDF 2004-05-04 01:01:00 UTC
Hi Tom,
Can you try this again with a nightly build, say April 30 (to avoid recent url
troubles) and let me know if this is still a problem. I still cannot reproduce
this, and I am tempted to close this off if there is no further issue.

http://www.slimdevices.com/downloads/nightly/
Comment 6 Tom Hahn 2004-06-01 23:21:40 UTC
Sorry I've been out of the loop.  I'll try to get to it this wkend.

-Tom
Comment 7 Henry Laxen 2004-06-11 17:06:59 UTC
Here is the problem, and a fix:

In Command.pm you call:
syncFunction($client,!$client->power(), "power",undef);
------------------------------------------------^^^^^^
Then in syncFunction the parameters are:
sub syncFunction {
	my $client = shift;
	my $newval = shift;
	my $setting = shift;
	my $controlRef = shift;
and later you do a:
&$controlRef($eachclient, $newval)

well, $controlRef is undef, which makes PERL very unhappy.  A simple fix, that
works fine for me is the following, just change the above line to:
  &$controlRef($eachclient, $newval) if defined $controlRef;
I hope this is helpful.
Best wishes,
Henry laxen
Comment 8 Blackketter Dean 2004-06-14 13:41:16 UTC
This was patched on 4/27.  Please try the latest nightlies and confirm that it's fixed.