Bug 2629 – Player info - Reports squeezebox2

Bug 2629 - Player info - Reports squeezebox2

Summary:

Player info - Reports squeezebox2

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	6.2.1
Platform:	PC All

Importance:	P3 minor (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-11-24 08:14 UTC by Brett Stark
Modified:	2008-09-15 14:38 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
munge model name (879 bytes, patch) 2005-11-28 14:58 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Brett Stark 2005-11-24 08:14:04 UTC

I have a version 3, firmware 28, yet it reports squeezebox2 in player info. It should report v3.

Comment 1 KDF 2005-11-24 13:09:14 UTC

The firmware is the same on SB2 and SB3. The server makes no distinction.

Comment 2 Blackketter Dean 2005-11-28 10:18:33 UTC

In the player info, we can distinguish SB3 from SB2 by MAC address:

SB3 starts at 00:04:20:06:00:00

Comment 3 KDF 2005-11-28 14:58:37 UTC

Created attachment 1055 [details]
munge model name

this ugly patch makes a special case for the sb3 based on mac address. if it is a match to the standard slim devices prefix, then check if the suffix is above the threshold where squeezebox2 becomes squeezebox 3.  This cannot be used in the $client->model method becuase the server uses that method for calling up image names.

Comment 4 KDF 2006-01-02 23:47:13 UTC

committed to trunk at change 5508, holding off on 6.2.2 until given the ok.
marking as a software bug for the remainder.

Comment 5 KDF 2006-01-20 21:19:31 UTC

*** Bug 2849 has been marked as a duplicate of this bug. ***

Comment 6 KDF 2006-02-09 00:38:25 UTC

Dean, do you want this in 6.2 or shall I close this off since it is in 6.5?

Comment 7 Blackketter Dean 2006-02-12 07:27:01 UTC

Please merge.  Thanks!

Comment 8 KDF 2006-02-12 10:12:54 UTC

done.  change 6217