Bug 2572 - Artwork not constrained in Default skin
: Artwork not constrained in Default skin
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 6.5b1
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-15 18:05 UTC by Greg Hamilton
Modified: 2008-09-15 14:37 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Browse artwork screenshot from 6.2 branch (155.17 KB, image/jpeg)
2005-11-17 10:51 UTC, sbjaerum
Details
Browse artwork screenshot from 6.5 branch (138.53 KB, image/jpeg)
2005-11-17 10:51 UTC, sbjaerum
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Hamilton 2005-11-15 18:05:29 UTC
When browsing by artwork, if there is not artwork, the tag is not contrained to the number of pixels.  This causes an unequal number of items per row.

It's okay in Fishbone, but doesn't work correctly in Default & Moser.
Comment 1 KDF 2005-11-15 18:23:58 UTC
Fishbone design sticks to the grid at the expense of cuttong off a tag if it goes too long, Default displays the entire tag at the cost of the grid. There really isn't any spec saying whether the grid is more important than the tags.  I expect that argument could go back and forth every release (just like so many other "bugs" that get "fixed").
Comment 2 Greg Hamilton 2005-11-16 18:59:02 UTC
Subject: Re:  Artwork not constrained in Default skin

On 11/15/05, Slim Devices Bugzilla <bugs@bugs.slimdevices.com> wrote:
>
> https://bugs-archive.lyrion.org/show_bug.cgi?id=2572
>
>
>
>
>
> ------- Comment #1 from slim-mail@deane-freeman.com 2005-11-15 18:23
> -------
> Fishbone design sticks to the grid at the expense of cuttong off a tag if
> it
> goes too long, Default displays the entire tag at the cost of the grid.
> There
> really isn't any spec saying whether the grid is more important than the
> tags.
> I expect that argument could go back and forth every release (just like so
> many
> other "bugs" that get "fixed").




consider this a vote for the grid being more important.

------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>
<br><br><div><span class="gmail_quote">On 11/15/05, <b class="gmail_sendername">Slim Devices Bugzilla</b> &lt;<a href="mailto:bugs@bugs.slimdevices.com">bugs@bugs.slimdevices.com</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<a href="https://bugs-archive.lyrion.org/show_bug.cgi?id=2572">https://bugs-archive.lyrion.org/show_bug.cgi?id=2572</a><br><br><br><br><br><br>------- Comment #1 from <a href="mailto:slim-mail@deane-freeman.com">slim-mail@deane-freeman.com
</a>&nbsp;&nbsp;2005-11-15 18:23 -------<br>Fishbone design sticks to the grid at the expense of cuttong off a tag if it<br>goes too long, Default displays the entire tag at the cost of the grid. There<br>really isn't any spec saying whether the grid is more important than the tags.
<br>I expect that argument could go back and forth every release (just like so many<br>other &quot;bugs&quot; that get &quot;fixed&quot;).</blockquote><div><br>
<br>
<br>
consider this a vote for the grid&nbsp; being more important.&nbsp;  <br>
</div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">------- You are receiving this mail because: -------<br>You reported the bug, or are watching the reporter.
<br></blockquote></div><br>
Comment 3 sbjaerum 2005-11-17 10:51:08 UTC
Created attachment 1022 [details]
Browse artwork screenshot from 6.2 branch

Why isn't it possible to let the string wrap into multiple lines confined to the allocated space in 6.5 as it is done in 6.2?

See the attached screenshots.
Comment 4 sbjaerum 2005-11-17 10:51:45 UTC
Created attachment 1023 [details]
Browse artwork screenshot from 6.5 branch
Comment 5 KDF 2005-11-17 11:01:02 UTC
are there two versions of firefox out there? This is not what I see at all, but the screenshot does seem to indicate that some template is missing.  Unfortunately, I reverted all my local stuff thinking it was useless test code.  I'll try to set up a fresh install and see if i can reconstruct.
thanks.
Comment 6 KDF 2005-11-17 11:12:44 UTC
oh ok, that was easy.  HTML/EN/browsedb_artwork.html, change line 2 to use [% item.size %] instead of [% size %]

I'll commit that tonight, and take a close look at my caching settings at home.  
Comment 7 sbjaerum 2005-11-17 11:17:11 UTC
You are FAST, works much better now.
Thanks.
Comment 8 KDF 2005-11-17 18:50:36 UTC
committed to trunk at change 5231
Comment 9 Chris Owens 2006-06-16 14:41:44 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.