What the...pasting from the PDF screwed up all the text I wrote.

The manual says: Press FAVORITES to jump to the list of favorite items you've saved.  Press and hold FAVORITES while displaying a song, radio station or playlist name to add it to your favorites list.

Pressing and holding favorites only seems to take you to the favorites menu, not add anything...

not bad.  feature documented before implemented.  some people should be very pleased ;)

not only is there no mapping for this function, but there seems to be no mention of the function.  was this accidentally missed in a commit somewhere, or does it need to be created?

I wrote that thinking that it'd get implemented in time.  It didn't, and I forgot.  So, yes it needs to be.  :)

*** Bug 3120 has been marked as a duplicate of this bug. ***

I keep getting more requests for this via support@slimdevices.com...

Created attachment 1158 [details]
the story so far

a partial patch showing progress.  This works on any mode that is properly using INPUT.* and when the object in question is a track or remoteURL.  I don't yet know what would be a good way to handle the selection of an album for example, which has no "url" associated with it.  Maybe an object type & id, with the comparable play functions.  not sure yet.

getting more complaints about this.  we promised a feature and didn't deliver.  bad news...

I can have my previous patch in 6.5 by tomorrow if you like, for broader testing.

initial attempt commmitted to trunk at change 6830 for april 6 build of 6.5.  Not sure how easy this will be to oprt into 6.2.2 since this current patch relies on INPUT.List being used.

I've merged this patch back to 6.2.2.

Chris - can you verify?

Thanks.

Subject: Re:  pressing and holding FAVORITES as described in the manual does not work as described

Chris: I'd like to either keep this bug open or open a new one for  
the additional ability to use the favorites button to save an artist,  
album, genre or playlist as a favorite for 6.5.

Sadly, pressing and holding 'favorites' on a clean installation of today's 6.2.2 build crashes slimserver.  I verified this on two different VMs.

crash was when in a mode that isn't INPUT.List, or selected an album/artist/genre right?  I'm actually not surprised.  The fix was ONLY valid for file urls (tracks or radio stations) when using INPUT.List.

need some simple way to store album/artist/genre by id, maybe like so:
artist:<id>
album:<id>
genre:<id>
playlist:<id>

long term solution needs to have these as valid urls, but shortterm it might be not too hard to just grab object type and id when writing, and reverse that for play.  would also allow the use of 'playlist addtracks' for playing a large playlist, and should speed things up for another bug I won't look up right now.

Marked as 'reopened'.  It actually crashes my 6.2.2 installs when I hold down favorites.

The event viewer message is: Can't use an undefined value as an ARRAY reference at /PerlApp/Slim/Buttons/Common.pm line 414.

that crash matches up with the lack of INPUT.List (or rather, specifically $client->param('listRef')).  Best to do a sanity check at least for $client->param('listRef') before going any further. 

Subject: Re:  pressing and holding FAVORITES as described in the manual does not work as described

Yeah, I'm working on fixing this.  There's at least one other place  
that crashes.  Will have a patch shortly.

fixed crasher for the next 6.2.2 build.  

I'm sorry but Favorites still don't work anymore whith SlimServer Version: 6.2.2 - 7135 (official) at home.
And no more whith SlimServer Version: 6.2.2 - 7209 (called 6.3.0 on download)

It's normal ?

verified this functionality does not work with 6.2.2-release.

Actually it works in some places.  But it does not work when you're on the now playing screen.

Need more specific documentation of this functionality.

Seems to only work if you're in browse and on a song, not on an album.  Also works in browse playlists on a playlist name.  But you can't add an album, an artist, a genre, or an internet radio stream as a favorite using the favorites button as far as I can tell.

That is correct.  albums/artists etc, don't have a url to store (see comment #6 and #13).  Also, what I know of the patch depended on INPUT.List being used (since other lists have only a local index var that isn't passed)

Sorry, this is going to need the new DB in 6.5

What's the status on this?

kdf - is your patch still valid? Does it need to be updated?

Thanks

My only patch was for INPUT.List, which was committed back at change 6830.  The status now is that any more not using INPUT.List won't work.  Not that many left in that category.  Browsedb lists won't work either becuase an album/artist/genre isn't a url.  Tracks will work.  We'd have to come up with a url format for albums/years/genres/artists, etc. One idea, I described above but am still waiting on feedback or a better suggestion.

Fixed in change 8665.

SlimServer now supports storing Albums, Artists, Genres, Playlists, Tracks & Years as Favorites.