Bug 2547 - Extra space in the Handheld skin after track fields
: Extra space in the Handheld skin after track fields
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 6.5b1
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-12 20:22 UTC by Alex
Modified: 2008-09-15 14:39 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
Screen capture of the problem (379.13 KB, image/jpeg)
2006-04-29 22:07 UTC, Alex
Details
put a space instead of tab only (732 bytes, text/html)
2006-04-30 00:15 UTC, Michael Herger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2005-11-12 20:22:22 UTC
The Handheld skin displays an extra space after a field name. For example:  "TITLE  from ALBUM  by ARTIST"

On a BlackBerry (OS v4.0.219) browser, the extra space causes the 2 spaces to be condenced into no space. The result is not pretty.
Comment 1 Blackketter Dean 2005-11-13 17:18:19 UTC
Alex:  I'm confused by this.  Are you saying that two spaces next to each other in the HTML get folded into zero spaces?  I've never heard of browser behavior like this before...
Comment 2 Alex 2005-11-13 18:57:18 UTC
(In reply to comment #1)
> Alex:  I'm confused by this.  Are you saying that two spaces next to each other
> in the HTML get folded into zero spaces?  I've never heard of browser behavior
> like this before...
> 
Correct. It appears that the skin contains the following fields after the TITLE and ALBUM fields: <TAB><TAB><TAB><LF><LF><TAB><TAB><TAB> (in hex: 09 09 09 0D 0A 0D 0A 09 09 09). Given that the intention of such a skin is for execution on a low bandwidth and low powered devices, such "extra" html formating is unnecessary. The BlackBerry Browser translates all that into no space. (I've also mentioned this to RIM as a bug.)
Comment 3 Michael Herger 2005-11-14 04:01:46 UTC
While the additional characters are clearly unnecessary (they result from the template toolkit code formatting), they should not be stripped to nothing at all. I don't know any standard, but in my experience it's usually replaced by one single space. You did right to inform RIM about it as well :-).

I fear we're getting more diversity to fight with Handheld than with any other skin... 
Comment 4 KDF 2006-04-28 17:07:09 UTC
Which pages are like this?  most of handheld pages are "title", without "by artist from album", at least in current builds.
Comment 5 Alex 2006-04-29 15:02:11 UTC
In the 6.5 builds, please select "Browse by album" in the Handheld skin.
Comment 6 Alex 2006-04-29 22:07:49 UTC
Created attachment 1212 [details]
Screen capture of the problem
Comment 7 Blackketter Dean 2006-04-29 22:29:02 UTC
A simple workaround for this would be to replace one of those tab characters with a space, I imagine.  Worth a shot and no harm done.  Michael: do you know where that is off the top of your head?
Comment 8 KDF 2006-04-29 22:48:58 UTC
HTML/Handheld/browsedbitems_list.html line 8. that's the line that adds the artistAsHTML bit.

Comment 9 Michael Herger 2006-04-30 00:15:36 UTC
Created attachment 1214 [details]
put a space instead of tab only

Alex, could you please put this file in HTML/Handheld and give it another try?

(and thanks to kdf for the pointer :-))
Comment 10 Michael Herger 2006-04-30 05:19:47 UTC
I did some work on the Handheld skin today. Could you please give tomorrow's build a try and give us some feedback here? Thanks!
Comment 11 Alex 2006-05-01 14:35:28 UTC
Looks good. Thanks.

Feel free to close out the bug if this is the permanent solution.
Comment 12 Michael Herger 2006-05-01 14:46:38 UTC
What's looking good: the file I attached here or the latest trunk?
Comment 13 Alex 2006-05-01 20:27:14 UTC
My appologies for the vagueness. The latest nightly build 7236 appears to address the problem on the Blackberry.

Thanks.
Comment 14 Michael Herger 2006-05-01 23:13:45 UTC
Very good. Thanks for the feedback!

(Could somebody close, please? I can't...)
Comment 15 KDF 2006-05-01 23:21:02 UTC
consider it done!