Bug 2541 - Errors with Softsqueeze links in slimserver web interface
: Errors with Softsqueeze links in slimserver web interface
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.5b1
: PC Windows XP
: P2 minor (vote)
: ---
Assigned To: Chris Owens
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-12 05:06 UTC by sbjaerum
Modified: 2009-09-08 09:23 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Softsqueeze startup page (127.25 KB, image/jpeg)
2005-11-12 05:09 UTC, sbjaerum
Details
Result from pressing Home in Softsqueeze startup page (105.49 KB, image/jpeg)
2005-11-12 05:10 UTC, sbjaerum
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sbjaerum 2005-11-12 05:06:55 UTC
I am having the following problem with Default skin (not tried other skins).

Click on link to Softsqueeze startup page.
The Softsqueeze startpage spans the whole browser (no left/right frame division).
This is shown in the first attached image.
To get back to the usual server page, I press the Home link.
Then the server menues appear, but no frame at the right with player controls, playlist etc.
This is shown in the second attached image.

Something must be wrong here...

I am using r5167 on WinXP with Firefox.
Comment 1 sbjaerum 2005-11-12 05:09:32 UTC
Created attachment 1006 [details]
Softsqueeze startup page
Comment 2 sbjaerum 2005-11-12 05:10:22 UTC
Created attachment 1007 [details]
Result from pressing Home in Softsqueeze startup page
Comment 3 KDF 2006-04-28 16:23:26 UTC
since the strings are hardcoded, the only way I can think of to avoid this problem for the greatest number of cases is to use a very uncommon string for target="", thus causing a new window/tab to open up for the softsqueeze page.  This would leave the slimserver skin intact for all cases.  Picking a used target would be tricky becuase some skins do not use frames.  

Breaking up NO_PLAYER_DETAILS string into incomplete chunks in order to insert a url via TT is another way to go, but so far we've tried to avoid cutting strings up as much as possible.
Comment 4 Dan Sully 2006-04-29 14:06:43 UTC
I'm not able to reproduce this using trunk + Firefox on XP.

Is this still an issue?
Comment 5 sbjaerum 2006-04-29 14:56:59 UTC
I still get the exact same behavior.
Comment 6 KDF 2006-04-29 19:04:42 UTC
Dan, you have to use the softsqueeze link from the "no player found" screen.  if you click on teh one on the home page, then it is already properly framed.  however, from the right side, it opens up to the full window and the home link them simply displays the home page full-window
Comment 7 Dan Sully 2006-04-29 19:48:03 UTC
I see the problem now.

Dean - what are your thoughts on this?

For skins like Handheld & Nokia770, there shouldn't be a target link, or it should be set to _top. But for skins like Default, the target link should be set to browser.
Comment 8 Blackketter Dean 2006-04-29 21:53:21 UTC
Subject: Re:  Errors with Softsqueeze links in slimserver web interface

Ah, the target for the link should be the same as the behavior as  
clicking on the SoftSqueeze link under help.

ON the default skin, that means the left frame.  Handheld, that means  
no frame, etc...


Comment 9 KDF 2006-04-30 00:03:58 UTC
right, trick is now, how best to take that url (with the target) out of the strings.txt
Comment 10 KDF 2006-07-25 23:27:12 UTC
This seems to be working with current code.  
Comment 11 Dan Sully 2006-07-26 06:32:32 UTC
Subject: Re:  Errors with Softsqueeze links in slimserver web interface

Really? What changed?

Comment 12 sbjaerum 2006-07-29 01:13:38 UTC
I still see the same issue with the 'Home' link.
Firefox on WinXP. Slimserver 6.5, version 8731.
Comment 13 KDF 2006-07-29 10:25:02 UTC
the link opens to _top for me, thus restoring the original layout.
Comment 14 sbjaerum 2006-07-29 10:41:13 UTC
With the correct frame layout in Default skin?
Comment 15 KDF 2006-07-29 10:47:42 UTC
yes.  guess I'll go back and check, make sure its not caching another skin.
it did appear to be working, even though I couldnt' find the change in code that was making it work.

I normally just use the back button.
Comment 16 KDF 2006-07-29 10:53:01 UTC
right, got it. must have pulled out the wrong bookmark.  looks like it must have been the 6.3 instance that I tested, which does work.
Comment 17 Michael Herger 2007-12-21 06:24:01 UTC
Fixed in SC7
Comment 18 Chris Owens 2008-03-07 09:03:42 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.