Bug 2498 - Abstract.pm uses RCS keyword for version - breaks when imported into CVS
: Abstract.pm uses RCS keyword for version - breaks when imported into CVS
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Misc
: 6.2.0
: PC Debian Linux
: P2 minor (vote)
: Future
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-05 08:22 UTC by Robin Cooksey
Modified: 2007-10-22 16:59 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Cooksey 2005-11-05 08:22:42 UTC
The file slimserver/CPAN/SQL/Abstract.pm uses an RCS keyword construct to
generate its version number:
$VERSION = do { my @r=(q$Revision: 1.20 $=~/\d+/g); sprintf "%d."."%02d"x$#r,@r };

This means that if you import the Slim server source into another CVS tree, and
fail to stop it from expanding RCS keywords, then the 1.20 will become whatever
the CVS revsion of the file in the new tree.  E.g., in my tree this became 1.1.1.3.

This is a problem because Abstract/Limit.pm says:
use SQL::Abstract 1.20;
which caused it to claim that I needed a new version of SQL::Abstract

This isn't a huge problem, as I imagine not many people want to re-import
Slimserver source into CVS - I do so to avoid having to copy plug-ins and
Custom.map files etc across for each version.

I realise that the use of the RCS keyword to generate a version number is
present in the CPAN source, not a Slim addition; but it does make it slightly
fragile.
Comment 1 Blackketter Dean 2007-10-22 16:59:08 UTC
Please ask the upstream author for a fix.