Bugzilla – Bug 2468
Artwork broken for album FLACs
Last modified: 2009-09-08 09:26:36 UTC
I have album FLACs with embedded cuesheets, and artwork functionality has stopped working. No artworks show up when doing 'Browse Artwork' and no artwork show up in other browse modes. I will attach an example FLAC file with accompanying artwork files. In Server Settings -> Interface, I have specified %ARTIST-ALBUM.jpg for Artwork and %ARTIST-ALBUM-thumb.jpg for Artwork Thumbnail. I have also specified Look For Artwork in Server Settings -> Performance. I am running trunk version 5002 on WinXP.
Created attachment 983 [details] Flac file
Created attachment 984 [details] Artwork
Created attachment 985 [details] Thumbnaile artwork
d_artwork seems to show that the album name isn't liked: "Variable Thumbnail: Frank Zappa And The Mothers Of Invention.jpg from ALBUM - ARTIST" Try renaming without the ! and see if that comes up with artwork. Other flac files are working in my library: "Variable Thumbnail: Contraband - VELVET REVOLVER.jpg from ALBUM - ARTIST" you can use d_artwork during the scan to keep an eye on the scan.
The ! is not the problem as I can't see artwork for any of my files, and most of my files do not contain any special characters (a bit unfortunate that my example file contain a ! in the file name...).
right, so then something to do with whole album. Odd, since the server clearly does get album info for the flac file. Do you have any that are not whole album?
Enabling --d_artwork I get: 2005-11-02 23:17:42.3195 Looking for image files in E:\audio\test\audio 2005-11-02 23:17:42.3259 Variable Thumbnail: Frank Zappa And The Mothers Of Invention.jpg from ARTIST-ALBUM-thumb 2005-11-02 23:17:42.3269 Image File empty or couldn't read: E:\audio\test\audio\Frank Zappa And The Mothers Of Invention.jpg 2005-11-02 23:17:42.3277 Image File empty or couldn't read: \Frank Zappa And The Mothers Of Invention.jpg 2005-11-02 23:17:42.3344 Completed Artwork Scan I get similar messages for all my files. For some reason the album name is not properly dealt with for album FLACs. Unfortunately, I don't have any properly tagged single track FLACs, but no reason to believe there is a problem with those since such files are working for you. Looks like the problem is limited to album FLACs. It has worked perfectly for me before. Not sure when it broke.
I see where it is failing, just not why. I'll try reverting later tonight to see if I can find the point where it worked. If you do remember a point post-6.2 where it worked, let me know (will save me some time going back day by day :))
This could be a problem. I've found the cause, and have a solution. The problem is that the solution turns out to be a partly a reversion of change 4495. This was done in order to fix bug 2219 and now results in this problem.
Created attachment 986 [details] the patch to make this work Here is what is needed to make the artwork show up. However, the changes in this in Track.pm are what were made to prevent genre munging due to conten-type confusion in bug 2219. I'm not sure how this can be resolved so that both are happy.
I can confirm that artworks are back again with this patch. Gordon, you were the reporter of bug 2219. There seems to have been several checkins to solve that problem. I'm not sure if change 4495 was the key change that fixed bug 2219. Would you mind testing if the patch that is attached to this bug breaks anything for you? It is not clear to me how the problem reported in bug 2219 is related to artwork...
Sorry, is this issue resolved? can we close the bug?
not yet, Dean. I have a fix, but I need to know what it's implications are against bug 2219 mentioned a few times in here. The fix is a partial reversion of one of several patches done to fix bug 2219. I was enver able to reproduce bug 2219 so I have no way of knowing if the fix for this will be causing problems there. As such, this patch has not been committed.
Can we apply the patch and then get the help of someone who was able to reproduce bug 2219 to verify that it's not newly broken? Also, dan do you have any thoughts on this?
ok. I'll merge it into traunk and branch tonight. I've not managed to figure out how cover art references could be getting in the way of the genre parsing. The only other method I could think of would been to rewrite the artwork routines to accept and manage objects. But then, it becomes a duplication of what is already being done with the objects prior to sending the url portion to artwork.
Yes - this should be ok.
committed to trunk at change 5052 to branch at change 5053, for Nov 5 nightly build of 6.2.1 please test and confirm. re-open if this causes any problems with this bug or bug 2219
This has broken again in r5104. You can use the same test files as before to reproduce.
Created attachment 1002 [details] variable cover art from flac files should use url, not filepath for files with cue sheets, the file path doesn't have the information we need to create the variable artwork. the call to infoFormat needs to link back to the object and not the filepath. This is a small change, and should fix the problem. I don't have artwork to go with it, but the log looks for the right filename.
Looks good. Sorry for the breakage.
ok. checked in at change 5114. should be ok now.