Bug 2450 – Picks plugin shows urls instead of titles

Bug 2450 - Picks plugin shows urls instead of titles

Summary:

Picks plugin shows urls instead of titles

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Plugin
Version:	6.2.0
Platform:	PC Windows (legacy)

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-10-31 14:56 UTC by KDF
Modified:	2008-09-15 14:37 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
updates for Parse.pm (1.09 KB, patch) 2005-10-31 15:54 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description KDF 2005-10-31 14:56:43 UTC

for one, it looks like format::Parse.pm has some incorrect logic in
_updateMetaData() at line 96.  Comment at line 95 says:

# Update title MetaData only if its not a local file with Title information
already cached.

Thus line 97 should probably be:
if ($title && !Slim::Music::Info::isFileURL($entry)) {

This doesn't seem to fix the urls appearing (yet) but I haven't gone past the
initial tests that lead to the above.

Comment 1 KDF 2005-10-31 15:52:54 UTC

patch coming shortly.

Comment 2 KDF 2005-10-31 15:54:48 UTC

Created attachment 974 [details]
updates for Parse.pm

check if the track is undef and add TITLE as well as for the case when defined
without a title.  Also includes the logic mentioned previously, and a \n to
cleanly finish off a debug msg.

Comment 3 Dan Sully 2005-10-31 16:16:23 UTC

Fixed in change 4971