Bug 2449 – Preamp Volume Control feature should not show up on SB1 player settings

Bug 2449 - Preamp Volume Control feature should not show up on SB1 player settings

Summary:

Preamp Volume Control feature should not show up on SB1 player settings

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.2.1
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-10-31 14:45 UTC by Kevin Pearsall
Modified:	2008-12-15 11:57 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin Pearsall 2005-10-31 14:45:08 UTC

but it does, in player settings -> audio for an sb1.

Comment 1 KDF 2005-10-31 15:16:31 UTC

add something like this before line 880 of Slim/Web/Setup.pm

	if ($client->isa("Slim::Player::Squeezebox2")) {
		$pageref->{'Groups'}{'Digital'}{'PrefOrder'}[1] = 'Transition';
	} else {
		$pageref->{'Groups'}{'Digital'}{'PrefOrder'}[1] = undef;
	}

might be more effected to add an client method for hasPreampControl() (same
concept as hasDigitalOut) instead, so that future players are easier to include.

Comment 2 KDF 2005-10-31 16:56:00 UTC

sorry. that's totally incomplete.  I'll create a patch for the trunk later with
th e client methods.

Comment 3 KDF 2005-10-31 18:35:58 UTC

committed a tested patch for this to trunk at change 4978

Comment 4 KDF 2005-10-31 21:21:58 UTC

merged to 6.2.1 at change 4980

Comment 5 James Richardson 2008-12-15 11:57:45 UTC

This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.