Bugzilla – Bug 2435
build-perl-modules.pl does not correctly check perlBinary - patch included
Last modified: 2008-09-15 14:37:04 UTC
In build-perl-modules.pl, the check: unless (-x $perlBinary) { die "Couldn't find a perl binary. Exiting.\n"; } is incorrect. If a user enters a directory such as /usr/bin, the test incorrectly succeeds (since directories are typically executatable). This actually happened in thread http://forums.slimdevices.com/showthread.php? p=61572#post61572 . The test should evaluate that perlBinary is a regular file as well: unless (-f $perlBinary && -x $perlBinary) { die "Couldn't find a perl binary. Exiting.\n"; } Can someone please update and commit the script? Thanks
done at change 4959 in trunk and in 6.2.x at change 4960
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006. I am setting them to targets of 6.2.1 to keep them from showing up in my queries.