Bugzilla – Bug 2362
Minor Fishbone skin issues
Last modified: 2008-09-15 14:37:04 UTC
With recent changes on trunk, I have noticed that there is a new Squeezebox logo on the top-right hand side. This has a black background that doesn't match the frame background. Also, I think this has pushed the display down slightly, so the white line just under it does not line up with the white line on the left hand side. Also, when I select a player that is remotely streaming, the FFWD (|<) and Rewind (>|) buttons are squished. They don't look as sharp as the buttons when a squeezebox player is selected.
The image is constrained so there is no change. The logo is standrd logo. I'm not going to toy with it, but Dean might be willing to provide a version with transparent background? The lines will not match as different browsers insist in having a different idea of what "height" means. I'm not following you on the last one. What has remotely steaming got to do with any graphics? Do you mean an http client, where the display DOES change?
1) until very recently, the lines did align. It's not a big deal though. 2) Yes, I meant an HTTP client.
1) I think you got lucky. I wasn't able to align them at the same times as the rest of the browsers so I gave up trying to align them in IE. Firefox, safari (sometimes opera) were ok. So far, I know that firefox is still ok. see if the overall browser width has any effect. 2) right, I know what's going on there. The height and width need to be set for non-players as well. will fix tonight. Dean, is the small logo using the same background colour as the large one? For some reason teh large logo look ok on Default, and that part of the Fishbone skin should be the same colour. Yet, in that case the small logo stands out like a sore thumb. I could constrain the large logo, but the render gets fairly ugly.
2 should now be fixed in change 4813 all I could find was a stale tag closer fixed in change 4814. that 'might' help with issue 1.
it seems the black background logo also affects the look of handheld and Touch skins. I'll try to look at alignment issues with IE tomorrow. If I can find anything I'll fix, otherwise I'm afraid that will have to be left as it is. After that, I think I'll relabel this for the logo work.
Your changes for part 1 didn't solve the alignment problem. However, now I'm using SVN, I can track what you did, so I knew where to look in the html. I found a fix that works for me here in IE. I haven't found out how to create a patch file for SVN yet, but my change is simple. I added border="0" cellpadding="0" cellspacing="0" to the table in the status.html, to match the table in pageheader.html. BTW, I thought that tables required <tr> tags to contain the <td>'s? IE doesn't seem to mind though.
how annoying. I'd removed all those to use a style instead. I guess IE does it again. Thanks. I will apply that shortly. tr tags are 'standard' but most browsers do seem to get it when you just use td.
committed to trunk in change 4856 and 6.2.1 at change 4857
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006. I am setting them to targets of 6.2.1 to keep them from showing up in my queries.