Bugzilla – Bug 2361
Statistics bars in handheld skin
Last modified: 2008-09-15 14:39:24 UTC
The bars on the right-hand side of each track on the statistics page are wrapping - I see 2/3 on one line, and 1/3 on the second line. DELL Axim X50, Windows Mobile 2003 Second Edition.
looks liks this is due to change 4409, artist and album info was added. I guess this can get too long. Perhaps the artist and album sections can be cut off (overlapping div?) so that the bars don't wrap at the end. That or I guess its back to the old title only style. Michael, probably a decision best left for you.
Created attachment 940 [details] Remove cell width definition Hmm... there seems again to be a difference between Opera and Pocket IE: on Opera it's the title-album-artist line that get's wrapped, but the bar stays in place (it's embraced by <nobr>). Does it look better if you remove the cell width parameter for the title's column? (see patch)
Created attachment 942 [details] Let's try to have the red bar unbreakable using CSS May be PocketIE does understand some CSS and respects "white-space: nowrap" more than <nobr> tags.
Philip, did you see any improvement with this patch?
Works fine in IE6. However, still not right with Pocket PC 2003 SE, which is what really matters. I currently see the bar wrap around two lines. Phil
I fear this is just a bug in PocketIE as all the other browsers we tested so far work ok. And even removing artist/album information wouldn't resolve this. Let's mark it WONTFIX? It's not THE crucial page (hey, Default users don't even have it, do they? :-))
I think it used to look okay in Pocket IE. Not sure how far back I need to go in history to find a working version. I will have a play, seeing that I can test it here with my device.
Phil, The last substantial change I can see in the hitlist's structure dates from quite a few months back: http://svn.slimdevices.com/*checkout*/trunk/server/HTML/Handheld/hitlist_list. html?rev=932 Try to download this file and put it in your Handheld folder. The links won't work. But is the layout better than now?
Created attachment 989 [details] Picture of the handheld skin stats page Yes, that displays better. The bars fit in one horizontal line without wrapping, although the bar isn't right-aligned (there is a fair amount of whitespace after the bars, I'd say roughly half of the total width of the bars). I have also played a track with a long name ("Coverville-050615-Dude, it's episode 99! What more did you want in the title?"), which wraps over three lines - the bars are still displayed on one line correctly.
Thanks for that feedback! I'll see if I can merge those two versions somehow.
Created attachment 1000 [details] don't break the images Phil, could you give this version a try. The change doesn't make much sense to me, but if it's looking better in Pocket IE...
That didn't work. However, I tried playing around with the column widths. Here's the results of my mucking about ;) I found that column widths of 75%, 5% and 20% worked better. Perhaps the difference is due to the width in pixels of the handheld device? Or perhaps Pocket IE gets confused when the scrollbar is displayed. Using %'s for the column widths is not great - If I display the handheld skin on the desktop PC and stretch the window wider, the wider the window, the bigger the excess spacing becomes between the track text and the number of times the track has been played. So if the skin were to be used on wider displays, or even if used in landscape instead of portrait mode, it might start to look iffy. I tried changing it to two columns 73% and 27%, with the (number) and bars together in the second cell together (separated with ). This was a little better. So I changed the widths to use pixels. As I now only had two columns, I only specified the final column width as width="70" - the first will resize as appropriate. This looks good with any window display width. One slight problem though is the (number) part seems to be displayed slightly lower (not vertically aligned with the position of the bars. I tried to use valign="center" and valign="middle", but neither seem to change the position of the content of the cell. So I finally changed back to 3 columns with the last two using fixed pixel sizes (2nd column width="20" align="center", 3rd ="45" align="right"), which corrected the vertical alignment. I guessed this would be a problem though when I had listened to some tracks a lot of times, such that the width of the number column would need increasing to avoid wrapping. Potentially, the 2nd cell could have been right aligned and made wider, but how many digits do we allow for, and what about font display size? So (and this was my final change!), I removed the fixed width size for the number column, and added some non-breaking spaces to pad the cell (I guess some cellspacing could be added to the table tag, but I didn't know where that bit comes from and it would affect all cells in the table). The order of the number column and the bars column could potentially be swapped, just so the number is separated from the track info text. Again, I need to listen to some tracks more often to try it with differing widths of numbers. I'll attach my final version - see what you think.
Created attachment 1001 [details] use fixed-width for the bars column
Checked your file in to the trunk as change 5115. Thanks!