Bug 2345 – Sync Group preferences can leak preferences

Bug 2345 - Sync Group preferences can leak preferences

Summary:

Sync Group preferences can leak preferences

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Sync
Version:	6.2.0
Platform:	PC All

Importance:	P3 normal (vote)
Target Milestone:	---
Assigned To:	Adrian Smith

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-10-23 12:56 UTC by Adrian Smith
Modified:	2008-09-15 14:37 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
potential fix (2.95 KB, patch) 2005-10-24 13:37 UTC, Adrian Smith	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Adrian Smith 2005-10-23 12:56:54 UTC

Preferences of the form *-Sync can be created and not removed with the code 
added in r4228.

Problem is due to sync state not being deleted from players in off state.

Comment 1 KDF 2005-10-23 13:53:55 UTC

The prefs can't really be deleted in off state because many of the sync features
are required to be restored when a player reconnects or turns on.  If sync-power
is not set, then a player drops from the group when turned off.  As each player
connects or turns on, it looks for groups to join based on the stored sync
information.

Comment 2 Adrian Smith 2005-10-23 13:57:40 UTC

Agreed - I added this as a place holder to make me fix it - I am working on a 
fix..

Comment 3 Adrian Smith 2005-10-24 13:37:58 UTC

Created attachment 936 [details]
potential fix

Potential fix - look for off players which are last in sync group and delete
state from them at unsync if only remaining player in sync group.

Comment 4 Adrian Smith 2005-10-28 11:55:34 UTC

Committed to trunk and 6.2 - 4773

Comment 5 Chris Owens 2006-06-16 14:41:38 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.