Bugzilla – Bug 2337
SVN 4722 breaks embedded cuesheet scanning
Last modified: 2008-09-15 14:36:01 UTC
Ok, I checked. It's definitely rev 4722: /trunk/server/Slim/Formats/Parse.pm "Check to make sure that files in a cue sheet exist on disk before blindly adding them to the database." This change broke scanning of whole-album flac files with embedded cuesheets. Most referenced flacs end up with 0 tracks. The test files I posted with bug 2219 will demonstrate the problem.
Critical crashes, loss of data, severe memory leak Major major loss of function
KDF: are you being critical of my critical assessment that this bug is critical? ;~| Not having a library to play from seems like a reasonably severe loss of function. But hey, I'm merely a lowly end user. If I wasn't a danger to myself and others when writing perl code, I'd offer to pitch in. As it stands, the only thing I have to offer is my seemingly uncanny ability to break the software and then whine about it.
Revision 4722 works for me, except that for filenames containing the Norwegian characters æøå, I get messages of the type: 2005-10-22 21:41:19.7513 parseCUE: Couldn't find referenced FILE: [E:\audio\flac\D\de_Lillos\de_Lillos-Suser_Avg+Ñrde-1985.flac] on disk! Skipping! The albums with filenames containing æøå is not part of the library after the scanning is finished. My library consists of flacs with embedded cue sheets and tags in the numbered vorbis comments format.
gordon, that was just a paste from the bugzilla docs to explain why I changed status. I have every understanding that it is critical for you, but in the end bugzilla is a developers tool and we do need to keep an objective level of organisation. Severe loss of function is where it is now. Can you use teh tool posted by Robin on the developer forum to trim your flac files down to just metadata and post a few example here. http://forums.slimdevices.com/showthread.php?t=17228&highlight=flac+script Steinar, if you occuld use the same script to post files for your reported issues, that would be great too.
Created attachment 927 [details] Test flacs that demonstrate the bug These are null flacs with embedded metadata cuesheets that don't seem to get scanned by 4722 and above.
Created attachment 928 [details] Flac causing problems: de_Lillos-Suser_Avgårde-1985.flac I think it is the file name (de_Lillos-Suser_Avgårde-1985.flac) not the tags inside the file that cause the problem in my case. I have many files with accented characters in tags that works fine. However this file has accented character in filename that seems to be problematic.
I should add that my slimserver runs on: Windows XP - EN - cp1252
Checkin 4738 has fixed the problems I encountered as a result of checkin 4722. However, the changes made in checkin 4724 cause my album titles to disappear.
Exactly the behavior I'm seeing too.
Fixed in change 4738
Dan: your rev 4741 fixed the null album title problem for me. Thanks!
Same for me, thanks a lot!