Bug 2313 - Overwrite playlist called "Untitled" crashes SlimServer
: Overwrite playlist called "Untitled" crashes SlimServer
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Playlists
: 6.2.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-18 12:08 UTC by Nigel Birch
Modified: 2008-09-15 14:36 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nigel Birch 2005-10-18 12:08:59 UTC
This is with "SlimServer Version: 6.2b1 - 4672 - Windows XP - EN - cp1252".

From the Default skin, if I create a playlist for a SB2 and start playing, then 
use the Save playlist option and choose the default name of "Untitled" and click 
Save, it says:

"Note: The name you chose is already taken. Please choose another name for your 
playlist, or check 'confirm overwrite' to replace your existing playlist."

I can't see any playlists called "Untitled" listed under "Home / Browse 
Playlists" or in the playlist folder I have specified ("C:\Program 
Files\SlimServer\server\Playlists").  Perhaps it's an internal name for 
something?

Choosing the Rename button (with or without ticking the "Confirm Overwrite" 
option) cause SlimServer to crash.  A -d_playlist gives:

C:\Program Files\SlimServer\server>perl slimserver.pl -d_playlist
2005-10-18 19:50:54.7486 Playlist: Jumping to song index: 0
2005-10-18 19:50:54.7519 Playlist: Jumping to song index: 0
2005-10-18 19:51:47.3589 Playlist: Jumping to song index: 0
2005-10-18 19:51:47.6019 Playlist: Jumping to song index: 0
2005-10-18 19:51:47.9759 Playlist: Jumping to song index: 0
2005-10-18 19:51:49.4846 End playlist build. 12 items
2005-10-18 19:51:49.6660 Playlist: Jumping to song index: 0
Can't locate object method "path" via package "Class::DBI::Object::Has::Been::De
leted" at C:/Program Files/SlimServer/server/Slim/Web/EditPlaylist.pm line 287.

Saving as "Untitled1" (which also doesn't exist under "Home / Browse Playlists" 
or the specified folder) doesn't prompt to overwite (as expected) and does save 
okay.
Comment 1 KDF 2005-10-18 17:25:52 UTC
removing line 232 of Web/EditPlaylist.pm seems to do the trick.  I'm not sure
why the server would have needed to have the current playlist object removed
from disk , so this might not be the right solution if that is necessary somehow.
Comment 2 Dan Sully 2005-10-18 22:16:24 UTC
Fixed in subversion change 4683.
Comment 3 Nigel Birch 2005-10-19 03:51:03 UTC
I upgraded to "6.2b1 - 4687 - Windows XP - EN - cp1252" and tried this again.

Choosing "Save" (on the playlist frame), keeping the name "Untitled" and not 
ticking the "Confirm Overwrite" checkbox, then choosing "Rename" doesn't crash 
the server - it just displays the same screen again.  So, thats's fixed.

However, if I do tick the "Confirm Overwrite" checkbox and choose "Rename", 
SlimServer still crashes.  The Windows event log shows:

"Can't locate object method "url" via package "Class::DBI::Object::Has::Been::
Deleted" at /PerlApp/Slim/DataStores/DBI/DBIStore.pm line 472."
Comment 4 Dan Sully 2005-10-21 14:57:16 UTC
Fixed in change 4726