Bug 2294 - Problems playing all songs by an artist
: Problems playing all songs by an artist
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.2.0
: Macintosh All
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-15 10:03 UTC by Blackketter Dean
Modified: 2008-09-15 14:37 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
more careful handling of findCriteria (407 bytes, patch)
2005-10-16 13:34 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2005-10-15 10:03:35 UTC
In Browse Music, selecting an artist displays an entry for each album by
the artist, plus an "All Songs" entry.

If you press right at the "All Songs" entry, then the SlimServer
correctly displays a list of all songs by the artist.

However, if you press "Play" at the "All Songs" entry, the Slimserver
creates a playlist with all songs in the library. This is incorrect -
it should be a playlist of all songs by the artist.

The same problem occurs if you select an artist in "Browse Music" and
press "Play". Every song in the database is played, instead of only the
songs by the selected artist.

(Win XP, latest SVN rev 4627)
Comment 1 KDF 2005-10-15 11:10:16 UTC
Executing command 00:04:20:05:ab:82: playlist (loadtracks)
(artist=10&contributor.role=&album.compilation=0)

looks like extra stuff in the findcriteria.  not sure what the contributor.role
shoudl be there, or even if it should be there at all.
Comment 2 KDF 2005-10-16 13:34:32 UTC
Created attachment 909 [details]
more careful handling of findCriteria

to fix bug 2271, I put in a patch to delete the artist param if the selection
is various artists (album.compilation=1), however, I only used the exists test,
since I didn't expect the param to be used on non-compilations.  this patch
makes sure the param is 1 instead of simply exiting.
Comment 3 Dan Sully 2005-10-16 17:01:42 UTC
You can just remove the exists.
Comment 4 KDF 2005-10-16 17:11:06 UTC
committed to trunk a change 4657
Comment 5 Chris Owens 2006-06-16 14:41:35 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.