Bugzilla – Bug 2291
Space in MusicMagic Mixer filter name causes playlist generation to fail
Last modified: 2008-09-15 14:37:04 UTC
Using 10-08 nightly and MusicMagic Mixer 1.1.6 A space in the name of a MusicMagic Mix filter causes MMM playlist generation to fail. It appears that the filter name is incorrectly formatted in the API between Slimserver and MMM. The filter name contains an actual space rather while spaces in the track or artist name are represented by %20 I don't know if this is a Slimserver or MMM issue. Create a filter on MMM called Exclude Folk Select the filter Exclude Folk on Home / Server Settings / MusicMagic Try to generate a MMM playlist by clicking the little "m" beside a track - a playlist is not generate and d_musicmagic_info log shows the following 2005-10-15 00:13:55.8966 MusicMagic: read cacheid of 1129325457 2005-10-15 00:13:55.9038 MusicMagic: got status - idle 2005-10-15 00:14:50.7561 MusicMagic: filter Exclude Folk in use. 2005-10-15 00:14:50.7571 MusicMagic: Creating mix for: song using: /Volumes/MusicServerLaCie/ SlimserverMusic/Lossy music/Afro Celt Sound System/Volume 1 Sound Magic/08 House of the Ancestors.m4a as seed. 2005-10-15 00:14:50.7576 Musicmagic: request http://localhost:10002/api/mix?song%3D% 2FVolumes%2FMusicServerLaCie%2FSlimserverMusic%2FLossy%20music%2FAfro%20Celt%20Sound% 20System%2FVolume%201%20Sound%20Magic%2F08%20House%20of%20the% 20Ancestors.m4a&variety=0&filter=Exclude Folk&style=0&sizetype=tracks&size=12 2005-10-15 00:14:50.7672 Musicmagic Error - Couldn't get mix: song%3D%2FVolumes% 2FMusicServerLaCie%2FSlimserverMusic%2FLossy%20music%2FAfro%20Celt%20Sound%20System% 2FVolume%201%20Sound%20Magic%2F08%20House%20of%20the% 20Ancestors.m4a&variety=0&filter=Exclude Folk&style=0&sizetype=tracks&size=12 Edit the filter name to remove the space - playlist is generated successfully 2005-10-15 00:17:43.0917 MusicMagic: ExcludeFolk 2005-10-15 00:17:43.1575 MusicMagic: get filters list 2005-10-15 00:17:43.1688 MusicMagic: found filters: 2005-10-15 00:17:43.1691 MusicMagic: ExcludeFolk 2005-10-15 00:17:53.9841 MusicMagic: get filters list 2005-10-15 00:17:53.9915 MusicMagic: found filters: 2005-10-15 00:17:53.9917 MusicMagic: ExcludeFolk 2005-10-15 00:18:30.8478 MusicMagic: filter ExcludeFolk in use. 2005-10-15 00:18:30.8481 MusicMagic: Creating mix for: song using: /Volumes/MusicServerLaCie/ SlimserverMusic/Lossy music/Afro Celt Sound System/Volume 1 Sound Magic/08 House of the Ancestors.m4a as seed. 2005-10-15 00:18:30.8485 Musicmagic: request http://localhost:10002/api/mix?song%3D% 2FVolumes%2FMusicServerLaCie%2FSlimserverMusic%2FLossy%20music%2FAfro%20Celt%20Sound% 20System%2FVolume%201%20Sound%20Magic%2F08%20House%20of%20the% 20Ancestors.m4a&variety=0&filter=ExcludeFolk&style=0&sizetype=tracks&size=12 2005-10-15 00:18:30.9199 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/Lossy music/Afro Celt Sound System/Volume 1 Sound Magic/08 House of the Ancestors.m4a : New / Volumes/MusicServerLaCie/SlimserverMusic/Lossy music/Afro Celt Sound System/Volume 1 Sound Magic/08 House of the Ancestors.m4a 2005-10-15 00:18:30.9210 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Lamb/What Sound/11 Just Is Edit.m4a : New /Volumes/MusicServerLaCie/ SlimserverMusic/Lossless music/Lamb/What Sound/11 Just Is Edit.m4a 2005-10-15 00:18:30.9216 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/Lossy music/Bebel Gilberto/Bebel Gilberto Remixed/All Around (Telefon Tel Aviv Mix).m4a : New /Volumes/ MusicServerLaCie/SlimserverMusic/Lossy music/Bebel Gilberto/Bebel Gilberto Remixed/All Around (Telefon Tel Aviv Mix).m4a 2005-10-15 00:18:30.9221 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Tom McRae/Just Like Blood/06 Walking To Hawaii.m4a : New /Volumes/ MusicServerLaCie/SlimserverMusic/Lossless music/Tom McRae/Just Like Blood/06 Walking To Hawaii.m4a 2005-10-15 00:18:30.9244 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Compilations/CafeÌ Mambo Ibiza 2005 [Disc 1]/1-10 La Ritournelle.m4a : New / Volumes/MusicServerLaCie/SlimserverMusic/Lossless music/Compilations/CafeÌ Mambo Ibiza 2005 [Disc 1]/1-10 La Ritournelle.m4a 2005-10-15 00:18:30.9252 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Deadly Avenger/Deep Red/05 The Quest Part 1.m4a : New /Volumes/MusicServerLaCie/ SlimserverMusic/Lossless music/Deadly Avenger/Deep Red/05 The Quest Part 1.m4a 2005-10-15 00:18:30.9257 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Massive Attack/Mezzanine/03 Teardrop.m4a : New /Volumes/MusicServerLaCie/ SlimserverMusic/Lossless music/Massive Attack/Mezzanine/03 Teardrop.m4a 2005-10-15 00:18:30.9261 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Goldfrapp/Supernature/11 Number 1.m4a : New /Volumes/MusicServerLaCie/ SlimserverMusic/Lossless music/Goldfrapp/Supernature/11 Number 1.m4a 2005-10-15 00:18:30.9265 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Compilations/Downtempo Grooves/12 Jericho - Caia.m4a : New /Volumes/ MusicServerLaCie/SlimserverMusic/Lossless music/Compilations/Downtempo Grooves/12 Jericho - Caia.m4a 2005-10-15 00:18:30.9268 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Blur/13/09 Trailer Park.m4a : New /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Blur/13/09 Trailer Park.m4a 2005-10-15 00:18:30.9272 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/Lossy music/The Streets/A Grand Don't Come for Free/10 Dry Your Eyes.m4a : New /Volumes/ MusicServerLaCie/SlimserverMusic/Lossy music/The Streets/A Grand Don't Come for Free/10 Dry Your Eyes.m4a 2005-10-15 00:18:30.9276 MusicMagic: Original /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Garbage/Garbage/02 Queer.m4a : New /Volumes/MusicServerLaCie/SlimserverMusic/ Lossless music/Garbage/Garbage/02 Queer.m4a
the whole string seems to be going through the uri escaping, but for some reason the filter name isn't being converted. something different with the way MMM puts spaces in the filter names?? OR maybe we need to utf8 encode teh filter name as well :)
Created attachment 906 [details] escape the filter name ok, for some reason, there is a note to avoid uri escaping the argstring. Unfortunately, this leaves the space in the space in the filter. So, how about just excaping the filter name. This patch also finishes a debug line with a carriage return and remove some old commented out code.
Looks good. Do you mean to remove the if (@$mix) .. stuff?
nope. that was part of the safari refresh bug that I forgot was in there. Just the first two hunks.
fixed at change 4625
Works fine in 6.2b2, thanks,
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006. I am setting them to targets of 6.2.1 to keep them from showing up in my queries.