Bugzilla – Bug 2289
Replaygain volume adjustment fails during ffwd/rew
Last modified: 2008-09-15 14:39:24 UTC
Replaygain volume adjustmet fails during ffwd/rew. Playing FLAC files, replaygained with foobar2000 software. Using Smart gain. In shuffle by song mode. See thread: http://forums.slimdevices.com/newreply.php?do=newreply&noquote=1&p=53053
Yann - did you change your convert.conf to include replaygain parameters on the flac command line?
Dan, I'll check out my convert.conf this eve. I don't remember changing anything manually. BTW: Flac = <built-in>
does the replaygain return when you go back into normal playback mode?
For me, it returns to normal on playback. But for others it doesn't (see thread)
Created attachment 905 [details] convert.conf
I take it back. On further investigation, the gain does =not= return to normal after scanning has stopped. Stopping or pausing has no effect, the track must be restarted by pressing rew and re-queuing the track.
We're not going to get to this for 6.2.
This behavior is also present with MP3 playback.
No one else seems to care for this request... and I've found alternative ways of doing this using Moose. No need to clutter up the request queue.
(In reply to comment #9) > No one else seems to care for this request... and I've found alternative ways > of doing this using Moose. No need to clutter up the request queue. > Whoops... sorry about that. Please ignore the above. I posted on the wrong bug. BTW: Is it possible to delete/edit bug comments?
Dean asserts we should fix this for 6.5. He thinks we are just not setting the replay gain when we ffwd, and only needs to happen on server side.
I believe that we're just not setting the replaygain value in the play slimproto command when in trick mode.
This should fix it: === Slim/Player/Source.pm ================================================================== --- Slim/Player/Source.pm (revision 15591) +++ Slim/Player/Source.pm (local) @@ -793,8 +793,14 @@ my $paused = ( Slim::Player::Sync::isSynced($client) ) ? 1 : 0; - $everybuddy->play($paused, $client->streamformat(), - Slim::Player::Playlist::song($client)); + $everybuddy->play( + $paused, + $client->streamformat(), + Slim::Player::Playlist::song($client), + 0, + $client->shouldLoop, + Slim::Player::ReplayGain->fetchGainMode($client), + ); $everybuddy->playmode("play"); }
I forced a FLAC file to -20db replaygain to test this. At scanning, it was still a the replaygained volume. I tested with MP3 as well altering a file of -9 to -30 to prove it works. it took a bit of shuffling, it seems that altering replaygain value isn't enough to change the timestamp and trigger a rescan of the file. I had to move them to new locations.
Fixed in change 9117