Bug 228 – Filenames with double quotes "skipped" by server during playback

Bug 228 - Filenames with double quotes "skipped" by server during playback

Summary:

Filenames with double quotes "skipped" by server during playback

Status:	RESOLVED DUPLICATE of bug 536

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Misc
Version:	unspecified
Platform:	Macintosh MacOS X 10

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-03-22 17:50 UTC by Jeff Sartain
Modified:	2011-03-16 04:18 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeff Sartain 2004-03-22 17:50:18 UTC

I'm running SlimServer 5.1.1 (release) on MacOS X 10.3.3.

I have an audio file with double quotes in the filename:

"V".flac

During playback, the server "skips" this track and goes on to the next.  The log
file contains an error from flac complaining that it cannot open the input file:

V.flac

The double quotes in the file name are stripped before they are passed to flac
(or the transcoding binary).  I removed the double quotes from the file name and
the server plays this file from the playlist correctly.

Comment 1 KDF 2004-03-25 21:38:50 UTC

generally, quotes are a bad thing to use in a filename.  Spaces too, so I can
see why this is annoying...

Comment 2 Jeff Sartain 2004-03-29 17:26:31 UTC

A bit of context: I pull FreeDB track info for a disc in a script and use this
to create track file names.  This information can contain all kinds of
characters which cause headaches.  I'm scanning these strings now using regular
expressions to get rid of the problematic ones.

If the music folder scan picks up the name correctly, then I would expect the
track to play (even if I understand why the double quotes cause problems for the
server).  Perhaps the rescan needs to weed these out?  Or print a list of
"problematic files" found during the scan?

Comment 3 Christian 2004-09-03 21:53:10 UTC

The problem only occurs if the Slimserver has to transcode the file.

See bug 536 for a proposed patch.

Christian

Comment 4 KDF 2004-09-04 00:52:13 UTC

so is bug536 a dupe of this one??

Comment 5 Jeff Sartain 2004-09-04 08:41:17 UTC

Yes, I believe this is the same issue addressed by the proposed patch to bug
536.   It's not just single and double quotes, though. Any characters which have
special meaning in the shell can cause problems, and not just during playback.  

I discovered recently that the server would skip scanning filenames which have
double periods ("..") in the file name or path. I had a number of instances of
"track_name....flac".  The files were scanned correctly once I removed the
ellipsis.  (The ellipsis comes from the freedb track title.)  

Having single and double quotes in file names is probably far more common, though.

Comment 6 Blackketter Dean 2004-09-04 08:59:20 UTC


*** This bug has been marked as a duplicate of 536 ***