Bug 2166 - Advanced Search form always has -1 results before the list
: Advanced Search form always has -1 results before the list
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.2.0
: All All
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-21 14:37 UTC by KDF
Modified: 2008-09-15 14:37 UTC (History)
0 users

See Also:
Category: ---


Attachments
numresults = -1 on no query, undef on query (535 bytes, patch)
2005-09-21 14:38 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2005-09-21 14:37:20 UTC
Pages.pm, advancedSearch() sets param{'numresults'} to -1, then later the
_fillSearchResults only calculates the results of !defined numresults.

If a small change is made to let numresults be -1 with no query, and undefined
during a query then the list can detect and show "empty" when there are no results.

patch shortly.
Comment 1 KDF 2005-09-21 14:38:05 UTC
Created attachment 843 [details]
numresults = -1 on no query, undef on query

allows detection of no results when numresults == 0
Comment 2 KDF 2005-09-21 20:55:05 UTC
fixed at change 4398 and 4400
Comment 3 Chris Owens 2006-06-16 14:41:30 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.