Bug 2110 - Server crash playing remote urls
: Server crash playing remote urls
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.2.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-09 17:33 UTC by Adrian Smith
Modified: 2008-09-15 14:36 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
make sure we have object (671 bytes, patch)
2005-09-24 13:09 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Smith 2005-09-09 17:33:02 UTC
Dan - several people (including me) have seen errors remote streaming cased by
Can't locate object method "url" via .... 
at /usr/local/trunk/server/Slim/Player/Source.pm line 1650.

[see http://forums.slimdevices.com/showthread.php?t=16261]

Its easily fixed by checking ref of $track, but is this symtomatic of a wider 
problem - remote streams being urls not objects?
Comment 1 Adrian Smith 2005-09-09 17:40:51 UTC
Also seen at /usr/local/slimserver/Slim/Player/Source.pm line 1723
Comment 2 Adrian Smith 2005-09-10 08:00:37 UTC
Dan - I've added 4229 as a temporary fix as it allows Alien to work without 
crashing the server.  Assuming you will have a more strategic solution later.
Comment 3 KDF 2005-09-10 17:55:36 UTC
*** Bug 2111 has been marked as a duplicate of this bug. ***
Comment 4 James Rome 2005-09-13 07:19:27 UTC
Crashed again last night:
Can't locate object method "path" via package
"file:///data1/playlists/Peer%20Gynt.m3u" (perhaps you forgot to load
"file:///data1/playlists/Peer%20Gynt.m3u"?) at
/usr/local/slimserver/Slim/Player/Playlist.pm line 595.
[3] 7809
Comment 5 KDF 2005-09-13 09:04:55 UTC
That crash line is different, and should have been fixed in change 4171 as part
of bug 2047.  How were you adding that URL to try to play?
Comment 6 James Rome 2005-09-13 11:01:04 UTC
I am using a build from 9/3. It died when I tried to either make or play the
item from a playlist. Do you think the current build has fewer bugs? I use Alien
BBC, and it seems to work for me now.
Comment 7 KDF 2005-09-13 11:12:11 UTC
the crash you mention was fixed Sept 6, so it should be an improvement over what
you have now, if you continue to run into that particular crash.
Comment 8 Dan Sully 2005-09-14 11:12:32 UTC
Is anyone having this issue with the 2005-09-14 build?
Comment 9 Dan Sully 2005-09-19 14:57:36 UTC
Is anyone still seeing this?
Comment 10 Adrian Smith 2005-09-19 15:00:18 UTC
Its OK for me.
Comment 11 Dan Sully 2005-09-19 15:14:16 UTC
Thanks. Please reopen if needed.

BTW - Is Alien calling 'getConvertCommand' directly?
Comment 12 David Brittain 2005-09-24 09:24:18 UTC
I am still seeing a similar problem (now on a different line in Source.pm) using
MMM 1.6 Beta, and yesterdays nightly build. It crashes after playing the first
song of the mix...

Can't locate object method "url" via package "file:///home/slimserver/flac_music
/Groovy%20Feeling/05%20-%20Groovy%20Feeling%20(Mr%20Whippy).flac" (perhaps you f
orgot to load "file:///home/slimserver/flac_music/Groovy%20Feeling/05%20-%20Groo
vy%20Feeling%20(Mr%20Whippy).flac"?) at /home/usr_local/slimserver/Slim/Player/S
ource.pm line 1797.
Can't locate object method "url" via package "file:///home/slimserver/flac_music
/Hello%20Nasty%20(Bonus%20Disc)/04%20-%20Peanut%20Butter%20&%20Jelly.flac" (perh
aps you forgot to load "file:///home/slimserver/flac_music/Hello%20Nasty%20(Bonu
s%20Disc)/04%20-%20Peanut%20Butter%20&%20Jelly.flac"?) at /home/usr_local/slimse
rver/Slim/Player/Source.pm line 1797.
Comment 13 KDF 2005-09-24 12:30:48 UTC
I'm not seeing this.  how are you starting the mix playback?
Comment 14 David Brittain 2005-09-24 12:36:22 UTC
Press and hold Play to create the mix and then pressing Play to start it. 
Comment 15 KDF 2005-09-24 13:09:45 UTC
Created attachment 855 [details]
make sure we have object

the crash is in getConvertCommand.  This is called from three places, two of
which look like they should safely have the object at all times.  however, due
to lazy conversion, I'm thinking that the Player::Playlist::song() might not
always have the object (for example, after loading a listref) so having that
check and return a proper object should avoid the crash. Havent had a chance to
test since I'm in the middle of another task
Comment 16 KDF 2005-09-24 20:05:57 UTC
tweaked the aforementioned patch, works to avoid the crash.  committed to trunk
at change 4426.
Comment 17 David Brittain 2005-09-26 15:46:27 UTC
Tested against 4430, no crash now. Thanks KDF.