Bug 2089 - switching languages causes blank entries on home page
: switching languages causes blank entries on home page
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Localization
: 6.2.0
: Macintosh All
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-07 08:31 UTC by Blackketter Dean
Modified: 2008-09-15 14:36 UTC (History)
0 users

See Also:
Category: ---


Attachments
clear plugins completely and reload (1.29 KB, patch)
2005-09-07 13:14 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2005-09-07 08:31:36 UTC
latest nightly, switched to spanish and plugin names on the home page were blank.  switching back to 
english didn't fix it.  restarting server did.
Comment 1 KDF 2005-09-07 12:13:50 UTC
Setup.pm has an 'onChange' for 'language' and Prefs.pm ALSO has 'language'
listedn in its %prefChange hash.  This means those routines are being called
twice.  This is not the cause of the problem, but should be cleaned up as part
of the solution.
Comment 2 KDF 2005-09-07 13:14:24 UTC
Created attachment 807 [details]
clear plugins completely and reload

the main problem is that initPlugins doesn't run the plugin strings routines if
the plugin is shown as already loaded.	On changing language, clear the plugins
hash to force a full reload.  Its a bit intensive, but works.
Comment 3 KDF 2005-09-07 13:17:20 UTC
darn, however, enabling or disabling will also call Plugins::clearGroups, so
clearing the plugins hash probably needs to be its own function:

sub clearPlugins {
   %plugins = {};
   clearGroups();
}

and call that from 'language'{'onChange'} instead of clearGroups.
Comment 4 Dan Sully 2005-09-07 13:21:25 UTC
Fix from kdf checked in as subversion change 4193.