Bug 2085 – Using remote 'add' to end of Playlist causes Playlist to restart

Bug 2085 - Using remote 'add' to end of Playlist causes Playlist to restart

Summary:

Using remote 'add' to end of Playlist causes Playlist to restart

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Playlists
Version:	6.2.0
Platform:	PC Debian Linux

Importance:	P2 major (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-09-07 03:10 UTC by Patrick Dixon
Modified:	2008-09-15 14:36 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Patrick Dixon 2005-09-07 03:10:21 UTC

svn 4156 / ubuntu / SB2

A short press of the 'add' button on the remote adds the song or album to the
end of the current Playlist (as expected), but also restarts the Playlist
playing from the begining of the first song again.

This doesn't appear to happen when adding to the end of the Playlist using the
web UI.

Comment 1 KDF 2005-09-07 09:30:09 UTC

what are you adding, from which browse mode?

Comment 2 Patrick Dixon 2005-09-07 09:43:05 UTC

Adding either an album or a song from Browse Music Folder mode.

Good point! - it seems to be Browse Music Folder specific, rather than SB remote
specific.

Comment 3 KDF 2005-09-07 10:50:07 UTC

so browse albums/artists, etc all work ok?

Comment 4 Patrick Dixon 2005-09-07 11:00:54 UTC

Yes - seem to.

Comment 5 KDF 2005-09-07 11:06:21 UTC

looks like a simple change.  Change Control/Command.pm line 533 to:
   my $jumpToIndex;

This leaves $jumpToIndex undefined for the 'add'/'insert' case, so that
load_done does not call Source::jumpto (which is what pops the playback to the
start, with the existing code since $jumpToIndex is set to 0 by default currently)

Comment 6 Dan Sully 2005-09-07 11:47:47 UTC

Fixed in subversion change 4191