Bugzilla – Bug 2038
The database should keep MusicBrainz IDs
Last modified: 2008-09-15 14:36:01 UTC
If available, the database should store the musicbrainz IDs from the tracks. One possible user of that data would be the SlimScrobbler plugin that reports listening habits to a central server. This patch against SVN 4110 reads MB metadata from FLAC, Ogg and MP3 files and stores it in the tables tracks, albums and contributors.
Created attachment 779 [details] Patch against SVN 4110 The patch uses the CPAN module MP3::Tag
Created attachment 786 [details] Patch against SVN 4144 This patch doesn't need MP3::Tag anymore and is verified to work with MP3s, Oggs and FLACs tagged with the MusicBrainz client. It needs a small modification to MP3::Info, though, which is in the next attachement
Created attachment 787 [details] Patch against SVN 4144 for MP3::Info This patch enables MP3::Info to return TXXX-Frames in get_mp3tag($fh) (which obtainst id3v1 tags and later overrides them with id3v2 ones)
Created attachment 809 [details] Patch against SVN 4218 New patch against 4218 since the patch for MP3::Info is already merged
Created attachment 817 [details] Patch against SVN 4275 Recreated patch because SVN revision 4258 introduced changes to the DBI layer.
Created attachment 827 [details] Patch against SVN 4294
I think this is a *great* feature and appreciate the work Hakan has put into it! I'm concerned about the seeming reluctance of SlimDevices to commit it. I can understand some of the reservations -- for example the performance implications of adding a special column (if this is even done, I haven't read the patch). If this is an issue is there a general metadata facility so that the tags can be stored without adding overhead if they aren't there at all? Musicbrainz is a wonderful facility and so is AudioScrobbler. If we can make the AudioScrobbler integration better then so much better. BTW how do you get MB metadata into FLAC? My MB tagger doesn't seem to read FLAC files -- or maybe I just haven't tried hard enough?
I used the MusicBrainz Picard (http://wiki.musicbrainz.org/PicardTagger) tagger. The old one would throw IllegalAccess faults while writing on my FLACs (thankfully it never destroyed any file), but Picard managed to write the tags perfectly. Regards, Hakan
cool I will have to check that out. I haven't been following the NG tagger development at all. thanks!
Slightly modified patch checked in as subversion change 4306. Call $obj->musicbrainz_id; to get the data - no need for the wrapper.
Created attachment 869 [details] Patch against 4450 with svn 4380, CPAN/MP3/Info.pm returns the TXXX frame keys in upper case. This patch fixes the mapping.
Applied as subversion change 4452