Bug 2002 – enabled() should NOT call initPlugin()

Bug 2002 - enabled() should NOT call initPlugin()

Summary:

enabled() should NOT call initPlugin()

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Plugins
Version:	6.2.0
Platform:	PC All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-08-20 14:35 UTC by Michael Herger
Modified:	2008-09-15 14:36 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
don't run initPlugin() from enabled() (758 bytes, patch) 2005-08-20 14:38 UTC, Michael Herger	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2005-08-20 14:35:52 UTC

The plugins' enabled() routine should not call initPlugin() as this will execute 
initPlugin() even for plugins that have been disabled, or twice for the others. 
MusicMagic for example tries to connect to its MM server during initialisation 
and will only continue after the timeout. This leads to very slow loading of the 
settings pages and home.html

Comment 1 Dan Sully 2005-08-20 14:37:00 UTC

Michael - go ahead and take those out.

Comment 2 Michael Herger 2005-08-20 14:38:03 UTC

Created attachment 749 [details]
don't run initPlugin() from enabled()

This patch only fixes iTunes and MusicMagic. Others might need this change,
too.

Comment 3 Dan Sully 2005-08-20 14:46:44 UTC

Go ahead and do all of them. I can't see how it's useful.

I know that RSS & PodCast spew all over the place with worthless garbage.

Comment 4 Michael Herger 2005-08-21 05:11:41 UTC

change 4016