Bug 1974 - Build Items Per Pass wrongly implemented in Pages.pm
: Build Items Per Pass wrongly implemented in Pages.pm
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.1.0
: All All
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-14 17:13 UTC by Nicolas Mizel
Modified: 2008-09-15 14:36 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Mizel 2005-08-14 17:13:50 UTC
Code should be as follows. Now with Build Items Per Pass = 1, the server checks
for idleStreams at each pass, thus allowing (at last) slow servers (like mine,
Mini-ITX VIA EDEN 522MHz) to refresh big playlists without causing dropouts.

[root@sirius Web]# diff --unified Pages.pm.orig Pages.pm
--- Pages.pm.orig       2005-07-21 02:21:38.000000000 +0200
+++ Pages.pm    2005-08-14 01:12:43.000000000 +0200
@@ -1123,7 +1123,7 @@
                $itemCount++;
 
                # don't neglect the streams for over 0.25 seconds
-               if ($needIdleStreams && $itemCount > 1 && $itemCount %
$itemsPerPass && (Time::HiRes::time() - $starttime) > 0.25) {
+               if ($needIdleStreams && $itemCount > 1 && !($itemCount %
$itemsPerPass) && (Time::HiRes::time() - $starttime) > 0.25) {
 
                        main::idleStreams();
                }

Regards,
Nicolas
Comment 1 Dan Sully 2005-08-14 20:49:25 UTC
Thanks!

Checked in as subversion change 3970.