Bugzilla – Bug 1974
Build Items Per Pass wrongly implemented in Pages.pm
Last modified: 2008-09-15 14:36:01 UTC
Code should be as follows. Now with Build Items Per Pass = 1, the server checks for idleStreams at each pass, thus allowing (at last) slow servers (like mine, Mini-ITX VIA EDEN 522MHz) to refresh big playlists without causing dropouts. [root@sirius Web]# diff --unified Pages.pm.orig Pages.pm --- Pages.pm.orig 2005-07-21 02:21:38.000000000 +0200 +++ Pages.pm 2005-08-14 01:12:43.000000000 +0200 @@ -1123,7 +1123,7 @@ $itemCount++; # don't neglect the streams for over 0.25 seconds - if ($needIdleStreams && $itemCount > 1 && $itemCount % $itemsPerPass && (Time::HiRes::time() - $starttime) > 0.25) { + if ($needIdleStreams && $itemCount > 1 && !($itemCount % $itemsPerPass) && (Time::HiRes::time() - $starttime) > 0.25) { main::idleStreams(); } Regards, Nicolas
Thanks! Checked in as subversion change 3970.