Bug 1940 - there should be no features in the help area
: there should be no features in the help area
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 6.1.2
: PC All
: P2 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-06 21:58 UTC by Jack Coates
Modified: 2009-09-08 09:30 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
move tune in now to radio setup page (2.96 KB, patch)
2005-08-07 12:52 UTC, KDF
Details | Diff
A simple "Tune In" plugin (1.87 KB, application/octet-stream)
2005-08-07 14:02 UTC, Michael Herger
Details
An improved simple "tune in" plugin :-) (4.39 KB, application/octet-stream)
2005-08-07 15:00 UTC, Michael Herger
Details
tune in radio section (non-plugin version) (8.20 KB, patch)
2005-08-13 12:33 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Coates 2005-08-06 21:58:43 UTC
there should be no features in the help area -- only help files. Currently the
Help area is the only way to launch Softsqueeze or to tune into Internet radio
stations.
Comment 1 Blackketter Dean 2005-08-06 22:54:57 UTC
Agreed.
Comment 2 KDF 2005-08-07 12:52:23 UTC
Created attachment 703 [details]
move tune in now to radio setup page

for EN skin only, but could be done for all in the same way, and would also
benefit from localisation.

not sure offhand where softsqueeze should go.  Personally, i think its not too
bad to have it there, since there is already an exposed link in the no_clients
page.
Comment 3 Michael Herger 2005-08-07 13:12:43 UTC
Is the settings page the right place to tune in to a radio station? Imagine 
somebody running slimserver with the nosetup parameter - no obvious way to tune 
into a radio station manually.

Is this too basic to be a plugin that can be added to the radio section of the 
main menu? 
Comment 4 KDF 2005-08-07 13:25:40 UTC
er, well, if they've CHOSEN to block setup, that's what they get :)

it was just one example.
Comment 5 Michael Herger 2005-08-07 14:02:15 UTC
Created attachment 704 [details]
A simple "Tune In" plugin

A very rough plugin that will display in the radio section if enabled. Needs
some more HTML work :-)
Comment 6 Michael Herger 2005-08-07 15:00:37 UTC
Created attachment 705 [details]
An improved simple "tune in" plugin :-)
Comment 7 KDF 2005-08-11 16:36:05 UTC
Is there much point in having this something that users can/might disable?  If
not, I'd say put the strings in strings.txt to make it easier for ongoing
translations.  Then the webPages() and handleWebIndex() bits can be folded into
Pages.pm and HTTP.pm respectively. One less checkbox in the plugins list :)
Comment 8 Michael Herger 2005-08-11 23:39:24 UTC
There might be users without hispeed internet access - no use for internet radio.

And hey, kdf, everybody doesn't have 40 plugins installed ;-). I'm even removing the stock plugins I 
don't use from my "production" server.
Comment 9 KDF 2005-08-11 23:56:40 UTC
I count 16 included plugins.
doesn't take 40. not that it had anything to do with this.
do what you like.  
Comment 10 Michael Herger 2005-08-13 12:33:02 UTC
Created attachment 723 [details]
tune in radio section (non-plugin version)

Kevin, I did not mean to bother you. I just wanted to give one reason why some
users might _not_ want a radio section - accompagnied by a not to be taken
seriously note concerning the 40 somewhat plugins you have on stock for tests.

Just in case Dean preferred a non-plugin version of the tunein	field: I've
attached a patch.
Comment 11 Michael Herger 2005-08-28 12:56:23 UTC
Ahem... what way are we going? Plugin or not plugin?
Comment 12 Blackketter Dean 2005-08-28 13:32:28 UTC
For internet radio tune in, I think it makes sense to have an item in the RADIO section rather than in the 
plugins section.  Call it "Tune in..." and put it at the end.

And, at the expense of making the bug have even more junk in it, I'd like to see Search above Radio 
(closer to the stuff it searches...)
Comment 13 KDF 2005-08-28 22:03:09 UTC
ok, moved the search for EN and Default. change 4105
Comment 14 Michael Herger 2005-08-31 12:12:30 UTC
Change 4109 adds a "tune in" menu to the radio section.