Bug 1918 - character display corrupt with large fonts
: character display corrupt with large fonts
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.2.0
: All All
: P2 minor (vote)
: ---
Assigned To: Adrian Smith
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-02 21:09 UTC by Ben Sandee
Modified: 2009-09-08 09:28 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Picture of corrupted SliMP3 display (43.33 KB, image/jpeg)
2005-08-03 07:14 UTC, Ben Sandee
Details
Possible patch (8.18 KB, patch)
2005-08-05 13:20 UTC, Adrian Smith
Details | Diff
Possible patch (8.18 KB, patch)
2005-08-05 13:20 UTC, Adrian Smith
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Sandee 2005-08-02 21:09:24 UTC
In the last few days a change has gone into the server trunk that corrupts all
my SliMP3 displays by not displaying text on most of top half of the screen.  My
SB2 is unaffected by this.  If necessary I can probably get a picture of the
corrupted screen but both of my SliMP3s exhibit the same problem so it should be
easy for anyone with access to one to duplicate.

This only happens with LARGE fonts, the small fonts seem to work fine.
Comment 1 Blackketter Dean 2005-08-02 21:33:40 UTC
Ben: are you using the nightly releases?  Your version number is marked as 6.1.0. 

Last night's nightly build works fine on my character player here in large font mode, is there a specific 
screen that exhibits the problem?
Comment 2 Ben Sandee 2005-08-03 07:09:26 UTC
Woops, messed the version up.  Yes I track the svn nightly and as of last night
it is more limited in its failure -- only the full-size clock power-off display
is halved.  All of the music control menus and screensavers seem to work fine.

Ill attach a picture of the display when its failing.

Changing the version and severity to reflect the new info.
Comment 3 Ben Sandee 2005-08-03 07:14:07 UTC
Created attachment 693 [details]
Picture of corrupted SliMP3 display

The picture shows the time 9:01 AM, you can see the top half is cut off.
Comment 4 Blackketter Dean 2005-08-03 07:24:53 UTC
*** Bug 1919 has been marked as a duplicate of this bug. ***
Comment 5 Blackketter Dean 2005-08-03 09:14:58 UTC
Whoops, I was not up to date on the system I was testing.  I see it now.  Will fix.
Comment 6 Blackketter Dean 2005-08-03 09:48:37 UTC
triode:  it looks like my checking is corrupting the top line in double-height datetime on character 
displays.  can you take a look at this?  If not, please assign it back to me.
Comment 7 Adrian Smith 2005-08-03 10:20:39 UTC
Will look at this weekend.
Comment 8 Adrian Smith 2005-08-05 13:20:19 UTC
Created attachment 697 [details]
Possible patch

I've modified the way doubling of text works on a character player in the
attached patch.  I think this avoids a couple of problems that centred double
text appeared to cause.

The patch should enable the bell symbol to appear on a character display for
both doubled and no doubled modes.  [If the alarm is set]

If you get the chance please test..
Comment 9 Adrian Smith 2005-08-05 13:20:38 UTC
Created attachment 698 [details]
Possible patch

I've modified the way doubling of text works on a character player in the
attached patch.  I think this avoids a couple of problems that centred double
text appeared to cause.

The patch should enable the bell symbol to appear on a character display for
both doubled and no doubled modes.  [If the alarm is set]

If you get the chance please test..
Comment 10 Ben Sandee 2005-08-05 13:41:52 UTC
looks good to me, my SliMP3's are happy again!

thanks!
Comment 11 Adrian Smith 2005-08-05 14:28:42 UTC
Patch commited to 6.2 trunk - r3878.
Comment 12 James Richardson 2008-12-15 11:57:35 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.