Bugzilla – Bug 186
iTunes library does not work on Linux
Last modified: 2004-02-21 15:37:04 UTC
I rsync my iTunes Library to my Linux home server. There is some special code in iTunes.pm that tries to cater for the necessary path name munging; unfortunately, it is missing out on a slash, which results in path names such as: 2004-02-11 12:24:53.2554 Cover Art (cover) for: /usr/local/slimserver/Music/iTunes/iTunes MusicHerbert Groenemeyer/? What's All This/01 What's All This.mp3 (note the missing slash between "Music" and "Herbert"). As a result, nothing plays. (You can't workaround by changing the base pathname in the Web UI, as trailing slashes get removed.) Fix: --- /tmp/iTunes.pm.old Wed Feb 11 13:04:59 2004 +++ iTunes.pm Wed Feb 11 13:02:29 2004 @@ -425,7 +425,7 @@ sub scanFunction { if (Slim::Utils::OSDetect::OS() eq 'unix') { my $base = Slim::Utils::Prefs::get('audiodir'); $::d_itunes && msg("Correcting for Linux: $iBase to $base\n"); - $url =~ s/$iBase/$base/isg; + $url =~ s/$iBase/$base\//isg; $url = Slim::Web::HTTP::unescape($url); }; $url =~ s/\/$//; I have been using this fix for a number of generations of the code now and can't find adverse effects.
great, thanks. I'll merge.
this broke it for me. what is the audiodir and ibase that needed this fix?
audiodir = /usr/local/slimserver/Music/iTunes/iTunes Music <key>Music Folder</key><string>file://localhost/Users/cabo/Music/iTunes/iTunes%20Music/</ string> What happens is that the latter has a trailing slash, which gets removed together with the rest of $iBase; so the audiodir string (which somewhere else loses any trailing slash) is put right ahead of the album directory name. If this breaks it for you, it must be because you now have a double slash -- how can a double slash break a Linux file name?
this might have been a red-herring. the symptom was lost cover art, which might have been caused by an earlier caching change and symptoms that went unnoticed until linux iTunes change. Strangely, removing the double slash would often seem to fix the problem. Server restart, however, showed the problem again. Will work on a proper cleanup to get rid of double slashes for all cases anyway. My case is with a music library based on a windows path (IT4Win): audiodir = /mnt/mp3 <key>Music Folder</key><string>file://localhost/J:/<string> <key>Location</key><string>file://localhost/J://Album%20Collection/PETER%20GABRIEL/Shaking%20The%20Tree/PETER%20GABRIEL%20-%20(14)%20Big%20Time.mp3/</string> replacing all double-/ with /, then doing sw/$ibase/$base/isg should do the trick.
Is this still an issue?
Works right out of the box now (just tried 2004-02-21 nightly). Who gets to mark this as CLOSED?