Bug 18140 – squeezebox1 gapless pcm broken - patch idea included

Bug 18140 - squeezebox1 gapless pcm broken - patch idea included

Summary:

squeezebox1 gapless pcm broken - patch idea included

Status:	UNCONFIRMED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Audio
Version:	7.8.0
Platform:	PC Linux (other)

Importance:	-- normal (vote)
Target Milestone:	---
Assigned To:	Unassigned bug - please assign me!

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-09-19 10:06 UTC by michael
Modified:	2015-09-20 10:01 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description michael 2015-09-19 10:06:03 UTC

This may be a re-open of 15490

symptom - short gap between wav files.

(can not see the code checkin for it)

I upgraded from 7.2.x to 7.8 and found gapless pcm broken

analysed the Squeezebox1.pm 
     sub isReadyToStream {

and found the comparison to allow pcm gapless is not working.
a ref to "currentTrack" is missing !


it needs the addition of currentTrack like so to work:

if (   $playingSong->channels   == $song->currentTrack->channels
       && $playingSong->samplesize == song->currentTrack->samplesize
       && $playingSong->samplerate == song->currentTrack->samplerate