Bugzilla – Bug 1813
Wrong linking of "all songs" at the bottom of the hierachy during browsing
Last modified: 2008-08-18 10:54:16 UTC
When selecting in SlimServer "browse albums" and then "all songs" on top of the song list again a hyperlink "all songs" is shown. Clicking on this hyperlinks should probably do nothing (since we are already in the "all songs" list) but does in fact lead list of all genres. On top of this genre list there is again a hyperlink for "all songs" but clicking on this link does nothing (so still all genres are shown but not all songs). The same is true when starting with "browse artists", "browse genres", "browse years", "new songs" (I don't have any artwork so I cannot comment "browse artwork"). Further, when I select "browse music folder" and then click on "all songs" shown on top of the list no song is shown on the next page but only the following lines are displayed: Play this song Add this song to the playlist Title: Musik File Format: Location: C:\temp\Musik (Download) Date Modified: Dienstag, Juli 5, 2005, 12:52:42
I think I'm getting to the poitn where I'd rather see every 'all' link disappear. WAY more trouble than they are worth.
All songs is not always for descending via a link, it is also a shortcut for playing all. However, sometimes the hierarchy ends up blank (when we've hit the bottom of a particular path). If their is no hierarchy, the best way to deal with this is to disable the descending link and keeping only the play/add links active. framing the link in [% IF hierarchy %] should take care of that. Dan,assign to me if you'd like to take care of that for 6.1
ok, will patch this tonight so leaving a note for myself for later. Seems that a lot of skins will need a tweak. BMF needs two changes to Pages.pm to mark the top level for Descend, and to undefine the hierarchy to that the 'all songs' link will just be static text.
committed to trunk at change 3698. part of nightly build for july 14. please re-open if any specific related issues remain.
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!